| Age | Commit message (Collapse) | Author |
|---|
|
solidusio-contrib/nirebu/190/move-subscription-processing-to-background-job
Move subscription processing to its own background job
|
|
solidusio-contrib/kennyadsl/use-new-factories-loading
Load factories using the new standard
|
|
solidusio-contrib/mr/admin-subscription-orders-listing
Admin: expose the subscription orders
|
|
solidusio-contrib/mr/cleanup-duplicated-fields-on-order-finalize
Cleanup the duplicated fields on subscription creation
|
|
Add a new tab in the member view of subscriptions to list the orders
processed by the current subscription.
|
|
Fix duplicated line items creation
|
|
|
|
This change moves the processing of individual subscriptions to their
own isolated jobs. The tasks of these individual jobs will be:
- Deactivate/Cancel subscriptions pending one of those operations
- Clear any past failed installment if it's configured to do so
- Create a new installment for the subscription cycle
- Enqueue a job to process any actionable installment for the
subscription
Given we've moved the concern of queueing the installment processing,
that part can be removed safely from the main processor job. The final
part of the change also touches the main processor job, whose task is
now to collect any actionable subscription and any subscription with
an actionable installment to enqueue them for individual processing.
|
|
|
|
solidusio-contrib/luca-landa/add-currency-to-subscriptions
Add currency to subscriptions
|
|
|
|
|
|
|
|
When we update a subscription with new line items, the logic is
assigning it twice. It's assigned in SubscriptionsController#update[1]
and in ResourceController#update[2].
It only happened with new line items because there's no id for them.
[1] https://github.com/solidusio-contrib/solidus_subscriptions/blob/69f0ca038b66d0ca36971405e51c0d3aa916cf19/app/controllers/spree/admin/subscriptions_controller.rb#L28
[2] https://github.com/solidusio/solidus/blob/b0092d0f3bda447494a586bf8eb96a18322b8bed/backend/app/controllers/spree/admin/resource_controller.rb#L36
|
|
The subscription payment method update on the admin panel was missing a
test. To make it easier to add those specs, it removes the subject and
let definitions in favor of making it explicit for each case.
|
|
|
|
Use `name` in customer serializer
|
|
Solidus 3.0 removes `first_name` and `last_name` from `Spree::Address`
so we should replace them with `name`. The Churn Buster documentation
would suggest it's OK to pass any customer properties we need, but I
have yet to get a developer account to verify.
|
|
Fix sandbox creation error
|
|
|
|
solidusio-contrib/deprecate-nested-subscription-attributes-from-user
Deprecate nested subscription attributes from user
|
|
Improve "unfulfilled" scope by adding subquery
|
|
Fix skip counters to handle skip limits
|
|
Processor and Checkout refactoring
|
|
These helpers are dangerous: they provide a false sense of assurance
by making you think that the order and the line item they return can
be used to infer the correct total value of future subscription orders.
In reality, order calculation in Solidus is an extremely complex process
that may take a ton of different parameters into account, and each store
is better off calculating the subscription total with their custom logic
rather than this extension trying to provide a solution that works for
everyone.
In the future, we may provide a way to compute a subscription's total,
but for the time being it's better to remove the helpers altogether.
|
|
It wasn't clear why certain business logic should live in `app/services`
while other should live in `lib`. By unifying everything in one directory,
we make it easier for developers to inspect the code and reduce the
cognitive load when implementing new classes.
|
|
Because it's very business-specific, this kind of change should be done
at the application level in a decorator, rather than embedding it in the
extension.
|
|
By setting the queue through a block rather than a boot-time method
call, we ensure to play nicely with configuration stubs and in other
non-obvious scenarios.
|
|
|
|
|
|
This service object contained a lot of indirection and took on too
many responsibilities. The new version is much more streamlined and
the flow of operations should be much clearer.
|
|
Instead of attempting to process multiple installments at a time, which
increases the chances something might go wrong, we are now only processing
one installment at a time.
This also improves the extension's performance, because the installments
can be processed in parallel.
|
|
|
|
The wrong filename prevented the spec from being executed.
|
|
"SolidusSubscriptions::Installment#unfulfilled" gets the list of
fulfilled installments, loads them ALL into memory, and then performs
a WHERE id NOT IN (...) to get the installments that were not fulfilled,
this commit simplify the scope using a WHERE clause with a subquery.
|
|
Increments "skip_count" and "successive_skip_count" Subscription
attributes when SolidusSubscriptions::Subscription#skip is called
so the skip limits are correctly handled.
|
|
The processor was way too complicated, taking on too many responsibilities.
As a result, it was complex to reason about and it was a very brittle part
of the extension.
The new processor simply does two things: it finds all actionable
subscriptions and ensures to take the appropriate action on them (e.g.,
cancel, deactivate), including creating the new installment for later.
Then, it finds all the actionable installments (including the ones that
were just created), and schedules them for asynchronous processing.
One side effect of this refactoring is that installments are not grouped
by address and payment method/source anymore: each installment will always
correspond to a new order. Any logistics-related optimizations should be
implemented by the individual store.
|
|
Fix typo in subscription admin notifications
|
|
|
|
Remove "canonical-rails" from the Gemfile
|
|
|
|
The canonical-rails was locked down to 0.2.9 because Solidus still used
the whitelisted_attributes method but with the new version 0.2.10 it
was renamed to allowed_parameters and it can be removed.
|
|
seand7565/update_permissions_on_subscriptions_user_tab
Update permissions check on user subscription tab
|
|
Previously, it would check your permissions on an ActiveRecord
association - which would in most non-admin cases be false, even
if they had permissions to manage subscriptions. This changes the
check to return a new instance of the users subscriptions, so
people with manage subscriptions permissions will still be able
to view this tab, while also allowing for you to conditionally
allow/deny permissions based on what users subscriptions they
are attempting to view.
|
|
Add Installment Details association to Order
|
|
This is useful if you want to connect orders to installments - for
instance, if you wanted to get a list of orders for a user that
are part of an installment.
|
|
seand7565/avoid_processing_installments_with_cancelled_subscriptions
Avoid processing installments with cancelled subscriptions
|
|
Anyone who cancels their subscription with a failed installment will
still have an order created the next time installments are created.
This is because installments don't check the status of their associated
subscriptions before being processed.
This update will ensure that only installments with active subscriptions
are processed.
|
|
Update cancel method on subscription to respect minimum date
|
|
Previously, the cancel method would check if the minimum
cancellation date minus the current day is in the future before
cancelling.
However, that adds one day to whatever minimum cancellation date
that you set - if you set one day, you would expect the user not
to be able to cancel on the day that the subscription ships, but
because the method checks if the date is in the future, the user
can't cancel the day of, or the day before.
This checks if the date is in the future OR if it's today, which
removes the added day from the minimum_cancellation_notice.
Also this sets the default to 0.days, as 1.day is pretty arbitrary
Lastly, this locks canonical-rails down to 0.2.9, because Solidus
still uses the `whitelisted_attributes` method, which was renamed
in 0.2.10
|
