Merge pull request #193 from solidusio-contrib/deprecate-nested-subscription-attributes-from-user

Deprecate nested subscription attributes from user

3 files changed, 28 insertions, 8 deletions

diff --git a/app/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb b/app/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb
index 561e5a1..1fb4cdf 100644
--- a/app/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb
+++ b/app/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb
@@ -14,6 +14,14 @@ module SolidusSubscriptions
 
           base.accepts_nested_attributes_for :subscriptions
         end
+
+        def subscriptions_attributes=(params)
+          ::Spree::Deprecation.warn(
+            'Creating or updating subscriptions through Spree::User nested attributes is deprecated. ' \
+            'Please use subscriptions APIs directly.'
+          )
+          super
+        end
       end
     end
   end
diff --git a/spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb b/spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb
deleted file mode 100644
index 4ef7491..0000000
--- a/spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb
+++ /dev/null
@@ -1,8 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe SolidusSubscriptions::Spree::User::HaveManySubscritptions, type: :model do
-  subject { Spree::User.new }
-
-  it { is_expected.to have_many :subscriptions }
-  it { is_expected.to accept_nested_attributes_for :subscriptions }
-end
diff --git a/spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions_spec.rb b/spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions_spec.rb
new file mode 100644
index 0000000..a76f130
--- /dev/null
+++ b/spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions_spec.rb
@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+RSpec.describe SolidusSubscriptions::Spree::User::HaveManySubscriptions, type: :model do
+  subject { Spree::User.new }
+
+  it { is_expected.to have_many :subscriptions }
+  it { is_expected.to accept_nested_attributes_for :subscriptions }
+
+  describe '#subscriptions_attributes=' do
+    it 'throws a deprecation warning' do
+      allow(::Spree::Deprecation).to receive(:warn)
+
+      subject.subscriptions_attributes = [{ interval_length: 2 }]
+
+      expect(::Spree::Deprecation)
+        .to have_received(:warn)
+        .with(/Creating or updating subscriptions through Spree::User nested attributes is deprecated/)
+    end
+  end
+end