summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlessandro Desantis <desa.alessandro@gmail.com>2021-02-05 14:39:52 +0100
committerGitHub <noreply@github.com>2021-02-05 14:39:52 +0100
commit4bd54e61e4f0c47664115171298e8875b4110c00 (patch)
treed882f1202e79e84b3a58faf0e77b6f5696626e5f
parentc2a8f6f37db7c099e971a2c5aec216df0e942b3f (diff)
parent90ea23c6911ff2454f66a90fbd8c377d3aec1a49 (diff)
Merge pull request #191 from solidusio-contrib/improve-unfulfilled-scope-query
Improve "unfulfilled" scope by adding subquery
-rw-r--r--app/models/solidus_subscriptions/installment.rb3
1 files changed, 1 insertions, 2 deletions
diff --git a/app/models/solidus_subscriptions/installment.rb b/app/models/solidus_subscriptions/installment.rb
index aed1f62..9477a42 100644
--- a/app/models/solidus_subscriptions/installment.rb
+++ b/app/models/solidus_subscriptions/installment.rb
@@ -19,8 +19,7 @@ module SolidusSubscriptions
end)
scope :unfulfilled, (lambda do
- fulfilled_ids = fulfilled.pluck(:id)
- where.not(id: fulfilled_ids).distinct
+ where.not(id: Installment.fulfilled).distinct
end)
scope :with_active_subscription, (lambda do