summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlessandro Desantis <desa.alessandro@gmail.com>2021-01-20 10:50:50 +0100
committerAlessandro Desantis <desa.alessandro@gmail.com>2021-01-30 15:23:41 +0100
commitce4edc06e6079d8c098f1d0754e3c8e31b355e2d (patch)
tree064f3682b13e2a67768314802859f6b2b546abfd
parent58972478854a4f8f137506591a186a4d528900b9 (diff)
Move all business logic to `lib`
It wasn't clear why certain business logic should live in `app/services` while other should live in `lib`. By unifying everything in one directory, we make it easier for developers to inspect the code and reduce the cognitive load when implementing new classes.
-rw-r--r--lib/solidus_subscriptions.rb9
-rw-r--r--lib/solidus_subscriptions/checkout.rb (renamed from app/services/solidus_subscriptions/checkout.rb)0
-rw-r--r--lib/solidus_subscriptions/dispatcher/base.rb (renamed from app/services/solidus_subscriptions/dispatcher/base.rb)0
-rw-r--r--lib/solidus_subscriptions/dispatcher/failure_dispatcher.rb (renamed from app/services/solidus_subscriptions/dispatcher/failure_dispatcher.rb)0
-rw-r--r--lib/solidus_subscriptions/dispatcher/out_of_stock_dispatcher.rb (renamed from app/services/solidus_subscriptions/dispatcher/out_of_stock_dispatcher.rb)0
-rw-r--r--lib/solidus_subscriptions/dispatcher/payment_failed_dispatcher.rb (renamed from app/services/solidus_subscriptions/dispatcher/payment_failed_dispatcher.rb)0
-rw-r--r--lib/solidus_subscriptions/dispatcher/success_dispatcher.rb (renamed from app/services/solidus_subscriptions/dispatcher/success_dispatcher.rb)0
-rw-r--r--lib/solidus_subscriptions/line_item_builder.rb (renamed from app/services/solidus_subscriptions/line_item_builder.rb)0
-rw-r--r--lib/solidus_subscriptions/subscription_generator.rb (renamed from app/services/solidus_subscriptions/subscription_generator.rb)0
-rw-r--r--lib/solidus_subscriptions/subscription_line_item_builder.rb (renamed from app/services/solidus_subscriptions/subscription_line_item_builder.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/checkout_spec.rb (renamed from spec/services/solidus_subscriptions/checkout_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/dispatcher/failure_dispatcher_spec.rb (renamed from spec/services/solidus_subscriptions/dispatcher/failure_dispatcher_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/dispatcher/out_of_stock_dispatcher_spec.rb (renamed from spec/services/solidus_subscriptions/dispatcher/out_of_stock_dispatcher_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/dispatcher/payment_failed_dispatcher_spec.rb (renamed from spec/services/solidus_subscriptions/dispatcher/payment_failed_dispatcher_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/dispatcher/success_dispatcher_spec.rb (renamed from spec/services/solidus_subscriptions/dispatcher/success_dispatcher_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/line_item_builder_spec.rb (renamed from spec/services/solidus_subscriptions/line_item_builder_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/subscription_generator_spec.rb (renamed from spec/services/solidus_subscriptions/subscription_generator_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/subscription_order_promotion_rule_spec.rb (renamed from spec/services/solidus_subscriptions/subscription_order_promotion_rule_spec.rb)0
-rw-r--r--spec/lib/solidus_subscriptions/subscription_promotion_rule_spec.rb (renamed from spec/services/solidus_subscriptions/subscription_promotion_rule_spec.rb)0
19 files changed, 9 insertions, 0 deletions
diff --git a/lib/solidus_subscriptions.rb b/lib/solidus_subscriptions.rb
index e9dae93..a052504 100644
--- a/lib/solidus_subscriptions.rb
+++ b/lib/solidus_subscriptions.rb
@@ -18,6 +18,15 @@ require 'solidus_subscriptions/churn_buster/subscription_customer_serializer'
require 'solidus_subscriptions/churn_buster/subscription_payment_method_serializer'
require 'solidus_subscriptions/churn_buster/subscription_serializer'
require 'solidus_subscriptions/churn_buster/order_serializer'
+require 'solidus_subscriptions/checkout'
+require 'solidus_subscriptions/line_item_builder'
+require 'solidus_subscriptions/subscription_generator'
+require 'solidus_subscriptions/subscription_line_item_builder'
+require 'solidus_subscriptions/dispatcher/base'
+require 'solidus_subscriptions/dispatcher/failure_dispatcher'
+require 'solidus_subscriptions/dispatcher/out_of_stock_dispatcher'
+require 'solidus_subscriptions/dispatcher/payment_failed_dispatcher'
+require 'solidus_subscriptions/dispatcher/success_dispatcher'
module SolidusSubscriptions
class << self
diff --git a/app/services/solidus_subscriptions/checkout.rb b/lib/solidus_subscriptions/checkout.rb
index 83fc35c..83fc35c 100644
--- a/app/services/solidus_subscriptions/checkout.rb
+++ b/lib/solidus_subscriptions/checkout.rb
diff --git a/app/services/solidus_subscriptions/dispatcher/base.rb b/lib/solidus_subscriptions/dispatcher/base.rb
index 30c5034..30c5034 100644
--- a/app/services/solidus_subscriptions/dispatcher/base.rb
+++ b/lib/solidus_subscriptions/dispatcher/base.rb
diff --git a/app/services/solidus_subscriptions/dispatcher/failure_dispatcher.rb b/lib/solidus_subscriptions/dispatcher/failure_dispatcher.rb
index 54f8f2b..54f8f2b 100644
--- a/app/services/solidus_subscriptions/dispatcher/failure_dispatcher.rb
+++ b/lib/solidus_subscriptions/dispatcher/failure_dispatcher.rb
diff --git a/app/services/solidus_subscriptions/dispatcher/out_of_stock_dispatcher.rb b/lib/solidus_subscriptions/dispatcher/out_of_stock_dispatcher.rb
index fe3e701..fe3e701 100644
--- a/app/services/solidus_subscriptions/dispatcher/out_of_stock_dispatcher.rb
+++ b/lib/solidus_subscriptions/dispatcher/out_of_stock_dispatcher.rb
diff --git a/app/services/solidus_subscriptions/dispatcher/payment_failed_dispatcher.rb b/lib/solidus_subscriptions/dispatcher/payment_failed_dispatcher.rb
index a56332e..a56332e 100644
--- a/app/services/solidus_subscriptions/dispatcher/payment_failed_dispatcher.rb
+++ b/lib/solidus_subscriptions/dispatcher/payment_failed_dispatcher.rb
diff --git a/app/services/solidus_subscriptions/dispatcher/success_dispatcher.rb b/lib/solidus_subscriptions/dispatcher/success_dispatcher.rb
index 0ae71dc..0ae71dc 100644
--- a/app/services/solidus_subscriptions/dispatcher/success_dispatcher.rb
+++ b/lib/solidus_subscriptions/dispatcher/success_dispatcher.rb
diff --git a/app/services/solidus_subscriptions/line_item_builder.rb b/lib/solidus_subscriptions/line_item_builder.rb
index c9aedb9..c9aedb9 100644
--- a/app/services/solidus_subscriptions/line_item_builder.rb
+++ b/lib/solidus_subscriptions/line_item_builder.rb
diff --git a/app/services/solidus_subscriptions/subscription_generator.rb b/lib/solidus_subscriptions/subscription_generator.rb
index 8153912..8153912 100644
--- a/app/services/solidus_subscriptions/subscription_generator.rb
+++ b/lib/solidus_subscriptions/subscription_generator.rb
diff --git a/app/services/solidus_subscriptions/subscription_line_item_builder.rb b/lib/solidus_subscriptions/subscription_line_item_builder.rb
index 7354102..7354102 100644
--- a/app/services/solidus_subscriptions/subscription_line_item_builder.rb
+++ b/lib/solidus_subscriptions/subscription_line_item_builder.rb
diff --git a/spec/services/solidus_subscriptions/checkout_spec.rb b/spec/lib/solidus_subscriptions/checkout_spec.rb
index 2a83d9b..2a83d9b 100644
--- a/spec/services/solidus_subscriptions/checkout_spec.rb
+++ b/spec/lib/solidus_subscriptions/checkout_spec.rb
diff --git a/spec/services/solidus_subscriptions/dispatcher/failure_dispatcher_spec.rb b/spec/lib/solidus_subscriptions/dispatcher/failure_dispatcher_spec.rb
index f247237..f247237 100644
--- a/spec/services/solidus_subscriptions/dispatcher/failure_dispatcher_spec.rb
+++ b/spec/lib/solidus_subscriptions/dispatcher/failure_dispatcher_spec.rb
diff --git a/spec/services/solidus_subscriptions/dispatcher/out_of_stock_dispatcher_spec.rb b/spec/lib/solidus_subscriptions/dispatcher/out_of_stock_dispatcher_spec.rb
index abb8343..abb8343 100644
--- a/spec/services/solidus_subscriptions/dispatcher/out_of_stock_dispatcher_spec.rb
+++ b/spec/lib/solidus_subscriptions/dispatcher/out_of_stock_dispatcher_spec.rb
diff --git a/spec/services/solidus_subscriptions/dispatcher/payment_failed_dispatcher_spec.rb b/spec/lib/solidus_subscriptions/dispatcher/payment_failed_dispatcher_spec.rb
index 0a222d4..0a222d4 100644
--- a/spec/services/solidus_subscriptions/dispatcher/payment_failed_dispatcher_spec.rb
+++ b/spec/lib/solidus_subscriptions/dispatcher/payment_failed_dispatcher_spec.rb
diff --git a/spec/services/solidus_subscriptions/dispatcher/success_dispatcher_spec.rb b/spec/lib/solidus_subscriptions/dispatcher/success_dispatcher_spec.rb
index 6a71800..6a71800 100644
--- a/spec/services/solidus_subscriptions/dispatcher/success_dispatcher_spec.rb
+++ b/spec/lib/solidus_subscriptions/dispatcher/success_dispatcher_spec.rb
diff --git a/spec/services/solidus_subscriptions/line_item_builder_spec.rb b/spec/lib/solidus_subscriptions/line_item_builder_spec.rb
index d1e041c..d1e041c 100644
--- a/spec/services/solidus_subscriptions/line_item_builder_spec.rb
+++ b/spec/lib/solidus_subscriptions/line_item_builder_spec.rb
diff --git a/spec/services/solidus_subscriptions/subscription_generator_spec.rb b/spec/lib/solidus_subscriptions/subscription_generator_spec.rb
index b7d73b8..b7d73b8 100644
--- a/spec/services/solidus_subscriptions/subscription_generator_spec.rb
+++ b/spec/lib/solidus_subscriptions/subscription_generator_spec.rb
diff --git a/spec/services/solidus_subscriptions/subscription_order_promotion_rule_spec.rb b/spec/lib/solidus_subscriptions/subscription_order_promotion_rule_spec.rb
index bacbef2..bacbef2 100644
--- a/spec/services/solidus_subscriptions/subscription_order_promotion_rule_spec.rb
+++ b/spec/lib/solidus_subscriptions/subscription_order_promotion_rule_spec.rb
diff --git a/spec/services/solidus_subscriptions/subscription_promotion_rule_spec.rb b/spec/lib/solidus_subscriptions/subscription_promotion_rule_spec.rb
index f4c65cc..f4c65cc 100644
--- a/spec/services/solidus_subscriptions/subscription_promotion_rule_spec.rb
+++ b/spec/lib/solidus_subscriptions/subscription_promotion_rule_spec.rb