summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlessandro Desantis <desa.alessandro@gmail.com>2021-01-20 10:37:41 +0100
committerAlessandro Desantis <desa.alessandro@gmail.com>2021-01-30 15:23:41 +0100
commit58972478854a4f8f137506591a186a4d528900b9 (patch)
tree2b45747201be718b6e5ba2aa776eab290891b25c
parentb4cd6b6e177df2603f370e050db291090668965e (diff)
Resume processing installments for cancelled subscriptions
Because it's very business-specific, this kind of change should be done at the application level in a decorator, rather than embedding it in the extension.
-rw-r--r--lib/solidus_subscriptions/processor.rb2
-rw-r--r--spec/lib/solidus_subscriptions/processor_spec.rb12
2 files changed, 1 insertions, 13 deletions
diff --git a/lib/solidus_subscriptions/processor.rb b/lib/solidus_subscriptions/processor.rb
index b5aaa70..ffc274b 100644
--- a/lib/solidus_subscriptions/processor.rb
+++ b/lib/solidus_subscriptions/processor.rb
@@ -5,7 +5,7 @@ module SolidusSubscriptions
class << self
def run
SolidusSubscriptions::Subscription.actionable.find_each(&method(:process_subscription))
- SolidusSubscriptions::Installment.actionable.with_active_subscription.find_each(&method(:process_installment))
+ SolidusSubscriptions::Installment.actionable.find_each(&method(:process_installment))
end
private
diff --git a/spec/lib/solidus_subscriptions/processor_spec.rb b/spec/lib/solidus_subscriptions/processor_spec.rb
index 03be168..e82c0e9 100644
--- a/spec/lib/solidus_subscriptions/processor_spec.rb
+++ b/spec/lib/solidus_subscriptions/processor_spec.rb
@@ -121,16 +121,4 @@ RSpec.describe SolidusSubscriptions::Processor, :checkout do
expect(subscription.reload.state).to eq('canceled')
end
end
-
- context 'with a cancelled subscription with pending installments' do
- it 'does not process the installment' do
- subscription = create(:subscription)
- create(:installment, subscription: subscription, actionable_date: Time.zone.today)
- subscription.cancel!
-
- described_class.run
-
- expect(SolidusSubscriptions::ProcessInstallmentJob).not_to have_been_enqueued
- end
- end
end