| Age | Commit message (Collapse) | Author |
|---|
|
solidusio-contrib/kennyadsl/log-installments-errors-by-default
Log installments errors by default
|
|
This way we can provide more flexibility on things that can be
done when an error occurs.
In the provided RailsLogger handler, we'll also print the ID
of the installment.
|
|
At the moment, by default, all installment prceissing errors are
swallowed and there's no way for a developer to understand what's
happening. Of course they can create a custom handler with the
processing_error_handler configuration provided but usually, when
the first errors happen, it's too late and those errors are lost.
We are not raising errors of this job because if there's a retry
mechanism in place for Active Job, the installment will be
reprocessed twice. Once by Active Job and once by the installment
retry mechanism already provided by the extension.
Logging to Rails.error is a middle-ground that allows to intercept
the message of the exception. Still, creating a custom handler
based on the bug tracker/exception handler used is the suggested
option here.
|
|
|
|
solidusio-contrib/add-order-creation-serviceish-object
Introduce Installment OrderCreator configuration
|
|
private
|
|
OrderCreator class and remove it from the configuration.
|
|
This adds both SolidusSubscriptions.configuration.order_creation_class and SolidusSubscriptions.configuration.order_creation_extra attributes, so that users can add attributes to each Installment Order at Checkout or even override how the Order is created
|
|
solidusio-contrib/dependabot/bundler/solidus_core-gte-2.0.0-and-lt-4
Update solidus_core requirement from >= 2.0.0, < 3 to >= 2.0.0, < 4
|
|
Fix Spree::OrdersController decoration
|
|
Updates the requirements on [solidus_core](https://github.com/solidusio/solidus) to permit the latest version.
- [Release notes](https://github.com/solidusio/solidus/releases)
- [Changelog](https://github.com/solidusio/solidus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/solidusio/solidus/compare/v2.0.0...v3.0.0.rc2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
|
|
|
|
Move all decorators to nested library (api, core, backend, frontend) decorators folder so they don't get loaded unless the library is defined.
|
|
The CreateSubscriptionLineItems decoration for the Front-end controller will break (obviously) if the Spree::OrdersController is not defined.
However, some users might want to use the extension using only the Backend and Core of Solidus.
This skips the decoration if Spree::Frontend is not defined
|
|
solidusio-contrib/fix-subscriptions-permitted-line-item-attributes
Fix Api Subscription Permitted LineItem Attributes
|
|
This removes a filter on the api SubscriptionsController that made it impossible to add a subscribable_id to the nested line_item_attributes (effectively prohibiting the creation of LineItems on the creation of a Subscription.
This allows the api to be more flexible but still allows users to limit certain operations by customizing the config.subscription_line_item_attributes
|
|
Reload order during finalize action
|
|
If you decorate the subscription generator to change the order
in any way (for instance, to associate the order to the
subscription), that change is not persisted in the rest of the
finalize action, as the order has already been loaded by that
point.
This can cause massive headaches with validations, so to fix it
I've added a reload method before super, so we can ensure that
the order is up-to-date before continuing.
This also means that subscription_line_items interval is nil,
since activating the subscription sets it to nil. So in the spec
we're fetching the interval from the subscription instead.
|
|
|
|
Setup the subcription create endpoint
|
|
not_to raise_error should never be ued with specific error classes,
since any other error would make the test pass, including the ones
raised by Ruby, meaning that the code being tested may never be reached.
|
|
We also check for the existence of the payment source class in order to
avoid a runtime error.
|
|
Mostly the same as update endpoint.
|
|
solidusio-contrib/christianr/payment-source-ownership
Validate payment_source ownership on the subscription
|
|
Update specs to conform with rubocop
|
|
|
|
solidusio-contrib/luca-landa/update-promotion-rule-names-on-db
Update promotion rule names on db
|
|
solidusio-contrib/ikraamg/skip-activejob-default-retry
Skip ActiveJob retrying for ProcessInstallmentJob
|
|
|
|
This disables the ActiveJob default retry mechanism because installment
processing failures are already taken care of by solidus_subscriptions.
Before this, there was a potentional for double retrying, which could
causes background jobs and cancelled orders to accumulate leading
to side effects such as a bad customer experience.
Now, a `process_job_error_handler` configuration Proc is called when a
ProcessInstallmentJob `#perfom` method fails.
The rescued error can be managed/logged as preffered, or re-raised
if the default retry behaviour is required in the job.
|
|
|
|
After
https://github.com/solidusio-contrib/solidus_subscriptions/pull/215
update promotion rule names on db to avoid STI errors.
|
|
|
|
|
|
solidusio-contrib/luca-landa/improve-promotion-rules-names
Improve promotion rules names
|
|
|
|
This displays a correct description in the admin panel
|
|
This allows for naming the models in a way more consistent to Solidus
(which doesn't include "PromotionRule" in the name of the class).
Also, it easily allows for the promotion rules to be displayed with a
better name in the admin panel (which just uses the promotions model
name humanized).
|
|
|
|
|
|
solidusio-contrib/luca-landa/set-default-currency-to-subscription
Set default config currency to subscription
|
|
|
|
Also add a spec that covers manual subscription creation from admin panel.
|
|
solidusio-contrib/elia/add-missing-permissions-sets-for-2-11
Add missing permissions sets for Solidus v2.11
|
|
solidusio-contrib/luca-landa/handle-subscriptions-with-deleted-products
Remove variant from subscriptions on soft deletion
|
|
Require a version of solidus_support that autoloads subscribers
|
|
|
|
|
|
Under v2.11 :display won't be enough anymore for :show controller
actions. The latter needs to be stated explicitly.
|
|
This is required in Solidus v2.11+.
|
