summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcesartalves <cesartalvez@gmail.com>2021-04-16 11:01:17 -0300
committercesartalves <cesartalvez@gmail.com>2021-04-16 11:01:17 -0300
commitd62df8a03899ca9d772131b3d40c84b9029d1676 (patch)
treeb361c81cc1e91774fb292bd9f3b2e6b8952910a4
parentd462e8eaaf6481f6e5434de575290442673fc538 (diff)
Fix Api Subscription Permitted LineItem Attributes
This removes a filter on the api SubscriptionsController that made it impossible to add a subscribable_id to the nested line_item_attributes (effectively prohibiting the creation of LineItems on the creation of a Subscription. This allows the api to be more flexible but still allows users to limit certain operations by customizing the config.subscription_line_item_attributes
-rw-r--r--app/controllers/solidus_subscriptions/api/v1/subscriptions_controller.rb2
-rw-r--r--lib/solidus_subscriptions/configuration.rb1
2 files changed, 2 insertions, 1 deletions
diff --git a/app/controllers/solidus_subscriptions/api/v1/subscriptions_controller.rb b/app/controllers/solidus_subscriptions/api/v1/subscriptions_controller.rb
index 0ac694d..5f0e58e 100644
--- a/app/controllers/solidus_subscriptions/api/v1/subscriptions_controller.rb
+++ b/app/controllers/solidus_subscriptions/api/v1/subscriptions_controller.rb
@@ -78,7 +78,7 @@ module SolidusSubscriptions
end
def line_item_attributes
- SolidusSubscriptions.configuration.subscription_line_item_attributes - [:subscribable_id] + [:id]
+ SolidusSubscriptions.configuration.subscription_line_item_attributes
end
def update_payment_attributes(attributes)
diff --git a/lib/solidus_subscriptions/configuration.rb b/lib/solidus_subscriptions/configuration.rb
index cbaec5c..2606272 100644
--- a/lib/solidus_subscriptions/configuration.rb
+++ b/lib/solidus_subscriptions/configuration.rb
@@ -52,6 +52,7 @@ module SolidusSubscriptions
def subscription_line_item_attributes
@subscription_line_item_attributes ||= [
+ :id,
:quantity,
:subscribable_id,
:interval_length,