diff options
| author | Nicholas Van Doorn <nick@super.gd> | 2021-05-12 14:04:44 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-12 14:04:44 -0700 |
| commit | 9ae8fa8dbd52727a4a4014cadfb63e54e9a65b52 (patch) | |
| tree | fdbcd3266a37a204c86e65688cd22626deff271e | |
| parent | d4553b0ede70d7ce5dc2dbb2d317393abdb92bee (diff) | |
| parent | e017998e4b4c7597b5e9dedf536700a9dd5c1d69 (diff) | |
Merge pull request #69 from Noah-Silvera/lock-execjs
Lock ExecJS and solidus extensions orb version
| -rw-r--r-- | .circleci/config.yml | 6 | ||||
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | Gemfile | 4 |
3 files changed, 6 insertions, 5 deletions
diff --git a/.circleci/config.yml b/.circleci/config.yml index ec33812..677f151 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,10 +1,6 @@ version: 2.1 orbs: - # Always take the latest version of the orb, this allows us to - # run specs against Solidus supported versions only without the need - # to change this configuration every time a Solidus version is released - # or goes EOL. - solidusio_extensions: solidusio/extensions@volatile + solidusio_extensions: solidusio/extensions@0.2.24 jobs: run-specs-with-postgres: diff --git a/CHANGELOG.md b/CHANGELOG.md index 7755eff..08e4491 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - [#51](https://github.com/SuperGoodSoft/solidus_taxjar/pull/51) Add nexus regions method to API - [#58](https://github.com/SuperGoodSoft/solidus_taxjar/pull/58) Take shipping promotions into account in default calculator - [#59](https://github.com/SuperGoodSoft/solidus_taxjar/pull/59) Add pry debugging tools +- [#69](https://github.com/SuperGoodSoft/solidus_taxjar/pull/69) Lock ExecJS version ## v0.18.1 @@ -13,6 +13,10 @@ gem "rails", ENV.fetch("RAILS_VERSION") { ">0.a" } # Provides basic authentication functionality for testing parts of your engine gem "solidus_auth_devise" +# ExecJS 2.8 has a bug in it which breaks js precompiling, which is required for our features +# specs. Many other solidus extensions are also experiencing failing specs because of this. +# For now, we should lock the version of ExecJS until a new release comes out that fixes this bug. +gem "execjs", '~> 2.7.0' case ENV["DB"] when "mysql" |