From a99a12737593c8fe9afad09bea908198e3e02ecf Mon Sep 17 00:00:00 2001 From: Noah Silvera Date: Wed, 12 May 2021 10:24:29 -0700 Subject: Lock ExecJS version ExecJS released a minor version update with a breaking change. We want to lock to the previous version (2.7) for now until a fix is released. Co-authored-by: Nick Van Doorn Co-authored-by: Adam Mueller --- Gemfile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Gemfile b/Gemfile index 8e43ed3..a11d93f 100644 --- a/Gemfile +++ b/Gemfile @@ -13,6 +13,10 @@ gem "rails", ENV.fetch("RAILS_VERSION") { ">0.a" } # Provides basic authentication functionality for testing parts of your engine gem "solidus_auth_devise" +# ExecJS 2.8 has a bug in it which breaks js precompiling, which is required for our features +# specs. Many other solidus extensions are also experiencing failing specs because of this. +# For now, we should lock the version of ExecJS until a new release comes out that fixes this bug. +gem "execjs", '~> 2.7.0' case ENV["DB"] when "mysql" -- cgit v1.2.3 From 268f05011372daaf5bd448d49a7e8c0a2158314a Mon Sep 17 00:00:00 2001 From: Nicholas Van Doorn Date: Wed, 12 May 2021 13:36:06 -0700 Subject: Lock `solidusio/extensions` orb to `0.2.24` A new version of `solidusio/extensions` has been released which runs the specs against Solidus 2.11. We are not ready for Solidus 2.11 yet, and the failing CI is blocking things, so we will avoid Solidus 2.11 for now, but we do want to support it eventually. --- .circleci/config.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ec33812..677f151 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,10 +1,6 @@ version: 2.1 orbs: - # Always take the latest version of the orb, this allows us to - # run specs against Solidus supported versions only without the need - # to change this configuration every time a Solidus version is released - # or goes EOL. - solidusio_extensions: solidusio/extensions@volatile + solidusio_extensions: solidusio/extensions@0.2.24 jobs: run-specs-with-postgres: -- cgit v1.2.3 From e017998e4b4c7597b5e9dedf536700a9dd5c1d69 Mon Sep 17 00:00:00 2001 From: Noah Silvera Date: Wed, 12 May 2021 10:26:44 -0700 Subject: Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7755eff..08e4491 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - [#51](https://github.com/SuperGoodSoft/solidus_taxjar/pull/51) Add nexus regions method to API - [#58](https://github.com/SuperGoodSoft/solidus_taxjar/pull/58) Take shipping promotions into account in default calculator - [#59](https://github.com/SuperGoodSoft/solidus_taxjar/pull/59) Add pry debugging tools +- [#69](https://github.com/SuperGoodSoft/solidus_taxjar/pull/69) Lock ExecJS version ## v0.18.1 -- cgit v1.2.3