summaryrefslogtreecommitdiff
path: root/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up
diff options
context:
space:
mode:
Diffstat (limited to 'app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up')
-rw-r--r--app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/events.patterns4
-rw-r--r--app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/keycode_events.snapshot8
-rw-r--r--app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/native_posix.keymap27
-rw-r--r--app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending9
4 files changed, 48 insertions, 0 deletions
diff --git a/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/events.patterns b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/events.patterns
new file mode 100644
index 0000000..cbf21af
--- /dev/null
+++ b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/events.patterns
@@ -0,0 +1,4 @@
+s/.*hid_listener_keycode_//p
+s/.*hid_register_mod/reg/p
+s/.*hid_unregister_mod/unreg/p
+s/.*zmk_hid_.*Modifiers set to /mods: Modifiers set to /p \ No newline at end of file
diff --git a/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/keycode_events.snapshot b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/keycode_events.snapshot
new file mode 100644
index 0000000..61dd271
--- /dev/null
+++ b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/keycode_events.snapshot
@@ -0,0 +1,8 @@
+pressed: usage_page 0x07 keycode 0x05 mods 0x02
+mods: Modifiers set to 0x02
+pressed: usage_page 0x07 keycode 0x04 mods 0x01
+mods: Modifiers set to 0x01
+released: usage_page 0x07 keycode 0x05 mods 0x02
+mods: Modifiers set to 0x01
+released: usage_page 0x07 keycode 0x04 mods 0x01
+mods: Modifiers set to 0x00
diff --git a/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/native_posix.keymap b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/native_posix.keymap
new file mode 100644
index 0000000..c603c00
--- /dev/null
+++ b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/native_posix.keymap
@@ -0,0 +1,27 @@
+#include <dt-bindings/zmk/keys.h>
+#include <behaviors.dtsi>
+#include <dt-bindings/zmk/kscan-mock.h>
+
+
+&kscan {
+ events = <
+ ZMK_MOCK_PRESS(0,1,10)
+ ZMK_MOCK_PRESS(0,0,10)
+ ZMK_MOCK_RELEASE(0,1,10)
+ ZMK_MOCK_RELEASE(0,0,10)
+ >;
+};
+
+/ {
+ keymap {
+ compatible = "zmk,keymap";
+ label ="Default keymap";
+
+ default_layer {
+ bindings = <
+ &kp LC(A) &kp LS(B)
+ &kp LCTL &none
+ >;
+ };
+ };
+};
diff --git a/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending
new file mode 100644
index 0000000..3f49005
--- /dev/null
+++ b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending
@@ -0,0 +1,9 @@
+This test fails because the hid_listener_keycode_released function
+releases implicit modifiers always, even if they were not set by the
+key that's going up. Also see the comment in that function:
+
+ If LC(A) is pressed, then LS(B), then LC(A) is released, the shift for B will be released
+ prematurely. This causes if LS(B) to repeat like Bbbbbbbb when pressed for a long time.
+ Solving this would require keeping track of which key's implicit modifiers are currently
+ active and only releasing modifiers at that time.
+