diff options
author | Okke Formsma <okke@formsma.nl> | 2020-09-02 22:30:09 +0200 |
---|---|---|
committer | Pete Johanson <peter@peterjohanson.com> | 2020-11-03 00:19:37 -0500 |
commit | 4f258efbf1602e212a808cc10915050a1b46e140 (patch) | |
tree | ed7601514e31895139ab91314610b2d570b1d326 /app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending | |
parent | a9e729b427800fab230fc1fcdacd3cbdb6bedc19 (diff) |
initial implementation for modifiers
https://github.com/zmkfirmware/zmk/issues/86
Diffstat (limited to 'app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending')
-rw-r--r-- | app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending new file mode 100644 index 0000000..3f49005 --- /dev/null +++ b/app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending @@ -0,0 +1,9 @@ +This test fails because the hid_listener_keycode_released function +releases implicit modifiers always, even if they were not set by the +key that's going up. Also see the comment in that function: + + If LC(A) is pressed, then LS(B), then LC(A) is released, the shift for B will be released + prematurely. This causes if LS(B) to repeat like Bbbbbbbb when pressed for a long time. + Solving this would require keeping track of which key's implicit modifiers are currently + active and only releasing modifiers at that time. + |