Add suggested changes

1 files changed, 13 insertions, 31 deletions

diff --git a/app/src/behaviors/behavior_rgb_underglow.c b/app/src/behaviors/behavior_rgb_underglow.c
index 7c83953..1207ed2 100644
--- a/app/src/behaviors/behavior_rgb_underglow.c
+++ b/app/src/behaviors/behavior_rgb_underglow.c
@@ -15,9 +15,6 @@
 
 LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
 
-struct behavior_rgb_underglow_config { };
-struct behavior_rgb_underglow_data { };
-
 static int behavior_rgb_underglow_init(struct device *dev)
 {
   return 0;
@@ -28,53 +25,38 @@ static int on_keymap_binding_pressed(struct device *dev, u32_t position, u32_t a
   switch (action)
   {
     case RGB_TOG:
-      zmk_rgb_underglow_toggle();
-      break;
+      return zmk_rgb_underglow_toggle();
     case RGB_HUI:
-      zmk_rgb_underglow_change_hue(1);
-      break;
+      return zmk_rgb_underglow_change_hue(1);
     case RGB_HUD:
-      zmk_rgb_underglow_change_hue(-1);
-      break;
+      return zmk_rgb_underglow_change_hue(-1);
     case RGB_SAI:
-      zmk_rgb_underglow_change_sat(1);
-      break;
+      return zmk_rgb_underglow_change_sat(1);
     case RGB_SAD:
-      zmk_rgb_underglow_change_sat(-1);
-      break;
+      return zmk_rgb_underglow_change_sat(-1);
     case RGB_BRI:
       zmk_rgb_underglow_change_brt(1);
-      break;
     case RGB_BRD:
-      zmk_rgb_underglow_change_brt(-1);
-      break;
+      return zmk_rgb_underglow_change_brt(-1);
     case RGB_SPI:
-      zmk_rgb_underglow_change_spd(1);
-      break;
+      return zmk_rgb_underglow_change_spd(1);
     case RGB_SPD:
-      zmk_rgb_underglow_change_spd(-1);
-      break;
+      return zmk_rgb_underglow_change_spd(-1);
     case RGB_EFF:
-      zmk_rgb_underglow_cycle_effect(1);
-      break;
+      return zmk_rgb_underglow_cycle_effect(1);
     case RGB_EFR:
-      zmk_rgb_underglow_cycle_effect(-1);
-      break;
+      return zmk_rgb_underglow_cycle_effect(-1);
   }
 
-  return 0;
+  return -ENOTSUP;
 }
 
 static const struct behavior_driver_api behavior_rgb_underglow_driver_api = {
   .binding_pressed = on_keymap_binding_pressed,
 };
 
-static const struct behavior_rgb_underglow_config behavior_rgb_underglow_config = {};
-
-static struct behavior_rgb_underglow_data behavior_rgb_underglow_data;
-
 DEVICE_AND_API_INIT(behavior_rgb_underglow, DT_INST_LABEL(0), behavior_rgb_underglow_init,
-                    &behavior_rgb_underglow_data,
-                    &behavior_rgb_underglow_config,
+                    NULL,
+                    NULL,
                     APPLICATION, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT,
                     &behavior_rgb_underglow_driver_api);
\ No newline at end of file