summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Johanson <peter@peterjohanson.com>2021-12-13 17:10:47 -0500
committerPete Johanson <peter@peterjohanson.com>2021-12-13 22:40:17 -0500
commitf438fb87d8765633e8550e1108a7956e9f5d70c2 (patch)
tree299f4b1776129e5686a47a9e9f4abbf36ad554a0
parentaf98a3fd6e5bd8b31e34416369d883eeb592c37c (diff)
chore: Add a few more items to PR template.
* Kconfig.defconfig conditional correctness. * Keyboard availability.
-rw-r--r--.github/pull_request_template.md2
1 files changed, 2 insertions, 0 deletions
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 7443c24..9c3543d 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -8,4 +8,6 @@
- [ ] Keymaps do not use deprecated key defines (Check using the [upgrader tool](https://zmk.dev/docs/codes/keymap-upgrader))
- [ ] `&pro_micro` used in favor of `&pro_micro_d/a` if applicable
- [ ] If split, no name added for the right/peripheral half
+ - [ ] Kconfig.defconfig file correctly wraps *all* configuration in conditional on the shield symbol
- [ ] `.conf` file has optional extra features commented out
+ - [ ] Keyboard/PCB is part of a shipped group buy or is generally available in stock to purchase (OSH/personal projects without general availability should create a zmk-config repo instead)