diff options
author | Jared Norman <jared@super.gd> | 2019-01-24 18:09:32 -0800 |
---|---|---|
committer | Jared Norman <jared@super.gd> | 2019-01-28 10:35:05 -0800 |
commit | c1bf02cf6586b537535956a98c3864d05ecdecc6 (patch) | |
tree | 8de541c411b7eb55adffc1ac7d6bf56cce9c04ff /lib/super_good/solidus_taxjar/api.rb | |
parent | 462aa5b334c44e7cef9536ebf0db2e98875031da (diff) |
Use DiscountCalculator and fix duplication
There's no reason for both the TaxCalculator and the API to have nearly
the same logic... so I unified that while was in there.
Diffstat (limited to 'lib/super_good/solidus_taxjar/api.rb')
-rw-r--r-- | lib/super_good/solidus_taxjar/api.rb | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/lib/super_good/solidus_taxjar/api.rb b/lib/super_good/solidus_taxjar/api.rb index ffefd5f..2504216 100644 --- a/lib/super_good/solidus_taxjar/api.rb +++ b/lib/super_good/solidus_taxjar/api.rb @@ -26,10 +26,6 @@ module SuperGood ) end - private - - attr_reader :taxjar_client - def order_params(order) tax_address = order.tax_address @@ -47,12 +43,20 @@ module SuperGood id: line_item.id, quantity: line_item.quantity, unit_price: line_item.price, - discount: -line_item.promo_total, + discount: discount(line_item), product_tax_code: line_item.tax_category&.tax_code } end } end + + private + + attr_reader :taxjar_client + + def discount(line_item) + ::SuperGood::SolidusTaxJar.discount_calculator.new(line_item).discount + end end end end |