diff options
| author | Jared Norman <jared@super.gd> | 2019-03-14 11:36:52 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-14 11:36:52 -0700 |
| commit | dd70baebce0b85e902c532219dc6dd464f7821c9 (patch) | |
| tree | 1211f366cbfff885bbe20df787e0d521854073c2 | |
| parent | 94dd3f5c2a86bd3b11c9a0f0b9cb6988505dd82d (diff) | |
| parent | ba7ec3f7cf1d97a9b17d0910a64a065f71c386e4 (diff) | |
Merge pull request #4 from SuperGoodSoft/explain-bug
Better explain the bug fix in v0.6.2
| -rw-r--r-- | CHANGELOG.md | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d5ded5..e82b911 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,15 @@ # Changelog ## v0.6.2 -- Updated `incomplete_address?` method to verify if a `tax_address` is a `Spree::Tax::TaxLocation`. `Spree::Tax::TaxLocation` is considered an incomplete address. + +- Fixed issued where orders without tax address would cause errors because `Spree::Order#tax_address` will return a `Spree::Tax::TaxLocation` when called on an order without a tax address. `Spree::Tax::TaxLocation` isn't enough like a real address and this was causing exceptions. + + To fix this `SuperGood::SolidusTaxJar#incomplete_address?` was updated to treat `Spree::Tax::TaxLocation`s as "incomplete". (Thanks to @JuanCrg90!) ## v0.6.1 +**Warning**: v0.6.1 has a critical bug and should not be used. + - Stopped using the deprecated method `Spree::Address#empty?` in favour of simply checking that we have all of the fields on the address required for doing a TaxJar lookup. ## v0.6.0 |