Fix coding style violations

1 files changed, 126 insertions, 130 deletions

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index cdaa6a2..4edc2f5 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,156 +1,152 @@
-Capybara/CurrentPathExpectation:
-  Enabled: false
-
-Capybara/FeatureMethods:
-  Enabled: false
-
-Layout/AlignHash:
-  Enabled: false
-
-Layout/ElseAlignment:
-  Enabled: false
-
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-
-Layout/EndAlignment:
-  Enabled: false
-
-Layout/IndentationWidth:
-  Enabled: false
-
-Layout/IndentFirstHashElement:
-  Enabled: false
-
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
-
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-09-24 12:23:52 UTC using RuboCop version 0.91.1.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 3
 Lint/AmbiguousBlockAssociation:
-  Enabled: false
-
-Lint/BooleanSymbol:
-  Enabled: false
-
-Metrics/LineLength:
-  Enabled: true
-  Max: 160
-
+  Exclude:
+    - 'spec/controllers/spree/admin/subscriptions_controller_spec.rb'
+    - 'spec/services/solidus_subscriptions/checkout_spec.rb'
+
+# Offense count: 1
+Lint/MissingSuper:
+  Exclude:
+    - 'app/services/solidus_subscriptions/user_mismatch_error.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
-  Enabled: false
-
-Rails/ApplicationJob:
-  Enabled: false
-
-Rails/ApplicationRecord:
-  Enabled: false
-
-Rails/Delegate:
-  Enabled: false
-
-Rails/DynamicFindBy:
-  Enabled: false
-
-Rails/HasManyOrHasOneDependent:
-  Enabled: false
-
-Rails/HttpStatus:
-  Enabled: false
-
-Rails/ReflectionClassName:
-  Enabled: false
-
-Rails/ReversibleMigration:
-  Enabled: false
-
-Rails/SafeNavigation:
-  Enabled: false
-
-Rails/SkipsModelValidations:
-  Enabled: false
+  Exclude:
+    - 'lib/solidus_subscriptions/processor.rb'
 
+# Offense count: 1
 RSpec/AnyInstance:
-  Enabled: false
+  Exclude:
+    - 'spec/jobs/solidus_subscriptions/process_installments_job_spec.rb'
 
+# Offense count: 46
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
 RSpec/ContextWording:
-  Enabled: false
-
-RSpec/LetSetup:
-  Enabled: false
-
-RSpec/EmptyLineAfterExample:
-  Enabled: false
-
-RSpec/EmptyLineAfterFinalLet:
-  Enabled: false
-
-RSpec/EmptyLineAfterHook:
-  Enabled: false
-
-RSpec/EmptyLineAfterSubject:
-  Enabled: false
-
-RSpec/ExpectChange:
-  Enabled: false
-
+  Exclude:
+    - 'spec/controllers/solidus_subscriptions/api/v1/line_items_controller_spec.rb'
+    - 'spec/controllers/spree/admin/subscriptions_controller_spec.rb'
+    - 'spec/lib/solidus_subscriptions/ability_spec.rb'
+    - 'spec/lib/solidus_subscriptions/processor_spec.rb'
+    - 'spec/models/solidus_subscriptions/installment_detail_spec.rb'
+    - 'spec/models/solidus_subscriptions/installment_spec.rb'
+    - 'spec/models/solidus_subscriptions/line_item_spec.rb'
+    - 'spec/models/solidus_subscriptions/subscription_spec.rb'
+    - 'spec/services/solidus_subscriptions/checkout_spec.rb'
+    - 'spec/services/solidus_subscriptions/line_item_builder_spec.rb'
+    - 'spec/services/solidus_subscriptions/order_builder_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
 RSpec/FilePath:
-  Enabled: false
-
-RSpec/ImplicitExpect:
-  Enabled: false
+  Exclude:
+    - 'spec/decorators/models/solidus_subscriptions/spree/order/finalize_creates_subscrptions_spec.rb'
+    - 'spec/decorators/models/solidus_subscriptions/spree/user/have_many_subscriptions.rb'
 
+# Offense count: 1
+# Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
-  Enabled: false
-
-RSpec/LeadingSubject:
-  Enabled: false
-
-RSpec/LetBeforeExamples:
-  Enabled: false
+  Exclude:
+    - 'spec/services/solidus_subscriptions/checkout_spec.rb'
 
+# Offense count: 18
+RSpec/LetSetup:
+  Exclude:
+    - 'spec/controllers/solidus_subscriptions/api/v1/subscriptions_controller_spec.rb'
+    - 'spec/decorators/controllers/solidus_subscriptions/spree/orders_controller/create_subscription_line_items_spec.rb'
+    - 'spec/lib/solidus_subscriptions/processor_spec.rb'
+    - 'spec/services/solidus_subscriptions/checkout_spec.rb'
+    - 'spec/services/solidus_subscriptions/line_item_builder_spec.rb'
+
+# Offense count: 8
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: have_received, receive
 RSpec/MessageSpies:
-  Enabled: false
+  Exclude:
+    - 'spec/services/solidus_subscriptions/failure_dispatcher_spec.rb'
+    - 'spec/services/solidus_subscriptions/out_of_stock_dispatcher_spec.rb'
+    - 'spec/services/solidus_subscriptions/payment_failed_dispatcher_spec.rb'
+    - 'spec/services/solidus_subscriptions/success_dispatcher_spec.rb'
 
+# Offense count: 2
 RSpec/MultipleExpectations:
-  Enabled: false
+  Max: 2
 
+# Offense count: 27
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 14
+
+# Offense count: 90
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Enabled: false
 
+# Offense count: 11
 RSpec/NestedGroups:
-  Enabled: false
-
-RSpec/NotToNot:
-  Enabled: false
-
-RSpec/PredicateMatcher:
-  Enabled: false
+  Max: 4
 
-RSpec/ScatteredLet:
-  Enabled: false
-
-Style/BracesAroundHashParameters:
-  Enabled: false
+# Offense count: 4
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/HasManyOrHasOneDependent:
+  Exclude:
+    - 'app/models/solidus_subscriptions/installment.rb'
+    - 'app/models/solidus_subscriptions/subscription.rb'
 
-Style/ClassAndModuleChildren:
-  Enabled: false
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/ReversibleMigration:
+  Exclude:
+    - 'db/migrate/20160922164101_add_interval_length_and_units_to_subscription_line_items.rb'
+    - 'db/migrate/20170106224713_change_line_item_max_installments_to_end_date.rb'
 
+# Offense count: 5
+# Configuration parameters: ForbiddenMethods, AllowedMethods.
+# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
+Rails/SkipsModelValidations:
+  Exclude:
+    - 'app/services/solidus_subscriptions/failure_dispatcher.rb'
+    - 'app/services/solidus_subscriptions/order_builder.rb'
+    - 'app/services/solidus_subscriptions/payment_failed_dispatcher.rb'
+    - 'spec/services/solidus_subscriptions/checkout_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
+# SupportedStyles: assign_to_condition, assign_inside_condition
 Style/ConditionalAssignment:
-  Enabled: false
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/spree/admin/subscriptions_controller.rb'
 
+# Offense count: 4
+# Configuration parameters: MinBodyLength.
 Style/GuardClause:
-  Enabled: false
-
-Style/MutableConstant:
-  Enabled: false
+  Exclude:
+    - 'app/models/solidus_subscriptions/subscription.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: compact, exploded
 Style/RaiseArgs:
-  Enabled: false
-
-Style/RegexpLiteral:
-  Enabled: false
-
-Style/SymbolProc:
-  Enabled: false
+  Exclude:
+    - 'app/services/solidus_subscriptions/checkout.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 290