diff options
| author | Aidan MacDonald <amachronic@protonmail.com> | 2021-08-04 20:22:37 +0100 |
|---|---|---|
| committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-08-06 15:46:53 +0000 |
| commit | 34fcea0b20d58dbf0fd091a864db4ee8aa5d554c (patch) | |
| tree | 319bdc76e106de101dbb4b8891cd65e2d58eea5d /firmware | |
| parent | 835d0c737a7e04f30b3990249ce461999ea2cf3a (diff) | |
Fix path buffer overflow in screendump
Overflow is due to a hidden assumption in create_datetime_filename()
and create_numbered_filename() where buffer must be >= MAX_PATH bytes.
Change-Id: I9d36517d861b6925352380d551afc5439edbb340
Diffstat (limited to 'firmware')
| -rw-r--r-- | firmware/screendump.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/firmware/screendump.c b/firmware/screendump.c index 1acaaafba6..7d09b0cd5e 100644 --- a/firmware/screendump.c +++ b/firmware/screendump.c @@ -102,7 +102,7 @@ static void (*screen_dump_hook)(int fh) = NULL; void screen_dump(void) { int fd, y; - char filename[32]; + char filename[MAX_PATH]; fb_data *src; #if LCD_DEPTH == 1 @@ -306,7 +306,7 @@ static const unsigned char rbmpheader[] = void remote_screen_dump(void) { int fd, y; - char filename[32]; + char filename[MAX_PATH]; fb_remote_data *src; #if LCD_REMOTE_DEPTH == 1 |