diff options
| author | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-19 10:54:26 +0100 |
|---|---|---|
| committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-20 22:41:29 +0100 |
| commit | 672bbe434b12d4730cf270f7245753fb98cf162d (patch) | |
| tree | 3fdaa08ddc41f942336c968bb169e8806c7c3fa8 /firmware/export/usb_drv.h | |
| parent | 99f333c64f13c3f9a62b9f5e184ae87f053bf65a (diff) | |
usb: rename usb_drv_recv() to usb_recv_recv_nonblocking()
IMHO the current name is somewhat misleading:
- usb_drv_send() is blocking and we have usb_drv_send_nonblocking()
for the non-blocking case. This inconsistent naming can only
promote confusion. (And what would we call a blocking receive?)
- Other hardware abstraction APIs in Rockbox are usually blocking:
storage, LCD, backlight, audio... in other words, blocking is the
default expected behavior, with non-blocking calls being a rarity.
Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af
Diffstat (limited to 'firmware/export/usb_drv.h')
| -rw-r--r-- | firmware/export/usb_drv.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/firmware/export/usb_drv.h b/firmware/export/usb_drv.h index 7ef7c8b7ee..01535c2786 100644 --- a/firmware/export/usb_drv.h +++ b/firmware/export/usb_drv.h @@ -68,8 +68,7 @@ void usb_drv_stall(int endpoint, bool stall,bool in); bool usb_drv_stalled(int endpoint,bool in); int usb_drv_send(int endpoint, void* ptr, int length); int usb_drv_send_nonblocking(int endpoint, void* ptr, int length); -int usb_drv_recv(int endpoint, void* ptr, int length); -void usb_drv_ack(struct usb_ctrlrequest* req); +int usb_drv_recv_nonblocking(int endpoint, void* ptr, int length); void usb_drv_set_address(int address); void usb_drv_reset_endpoint(int endpoint, bool send); bool usb_drv_powered(void); |