diff options
| author | Thomas Martitz <kugel@rockbox.org> | 2014-01-12 01:30:26 +0100 |
|---|---|---|
| committer | Thomas Martitz <kugel@rockbox.org> | 2014-01-12 01:34:06 +0100 |
| commit | 488a1b983e1c2fac14de25aa781caf12628e53c8 (patch) | |
| tree | 8d5b5b33e0c7eb9e5222b843f84c6b2d65d1a352 /firmware/export/lcd.h | |
| parent | 656261bde1122612d1bf8ffc3c992c75a7fbc52e (diff) | |
put_line/scrolling: Make the scroll engine inform custom scrollers about start/stop of scrolling.
With the new lcd_putsxy_scroll_func() code can register custom scroll functions
(put_line() makes use of that). In order for the custom scroller to be able
to properly manage its userdata pointer (set via struct scrollinfo::userdata)
the scroll engine must inform the scroller about start and stop of scrolling.
To inform about start the lcd_scroll_* functions now return true when
the line will scroll. To inform about stop the scroll engine calls into the
scroller one last time, with the text set to NULL.
put_line() can use this to release the userdata registered per scrolling line
so that it can be recycled.
This fixes that some scrolling lines became glitchy after some time because
the userdata was recycled too early.
Change-Id: Iff0a6ce2a4f9ae2bada1b8e62f4f5950224942a9
Diffstat (limited to 'firmware/export/lcd.h')
| -rw-r--r-- | firmware/export/lcd.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/firmware/export/lcd.h b/firmware/export/lcd.h index 87476d9dda..386ac5a8bf 100644 --- a/firmware/export/lcd.h +++ b/firmware/export/lcd.h @@ -179,8 +179,8 @@ extern void lcd_putsxy_style_offset(int x, int y, const unsigned char *str, extern void lcd_puts(int x, int y, const unsigned char *string); extern void lcd_putsf(int x, int y, const unsigned char *fmt, ...); extern void lcd_putc(int x, int y, unsigned long ucs); -extern void lcd_puts_scroll(int x, int y, const unsigned char* string); -extern void lcd_putsxy_scroll_func(int x, int y, const unsigned char *string, +extern bool lcd_puts_scroll(int x, int y, const unsigned char* string); +extern bool lcd_putsxy_scroll_func(int x, int y, const unsigned char *string, void (*scroll_func)(struct scrollinfo *), void *data, int x_offset); |