diff options
| author | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-19 10:54:26 +0100 |
|---|---|---|
| committer | Aidan MacDonald <amachronic@protonmail.com> | 2021-09-20 22:41:29 +0100 |
| commit | 672bbe434b12d4730cf270f7245753fb98cf162d (patch) | |
| tree | 3fdaa08ddc41f942336c968bb169e8806c7c3fa8 /firmware/drivers/usb-designware.c | |
| parent | 99f333c64f13c3f9a62b9f5e184ae87f053bf65a (diff) | |
usb: rename usb_drv_recv() to usb_recv_recv_nonblocking()
IMHO the current name is somewhat misleading:
- usb_drv_send() is blocking and we have usb_drv_send_nonblocking()
for the non-blocking case. This inconsistent naming can only
promote confusion. (And what would we call a blocking receive?)
- Other hardware abstraction APIs in Rockbox are usually blocking:
storage, LCD, backlight, audio... in other words, blocking is the
default expected behavior, with non-blocking calls being a rarity.
Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af
Diffstat (limited to 'firmware/drivers/usb-designware.c')
| -rw-r--r-- | firmware/drivers/usb-designware.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/firmware/drivers/usb-designware.c b/firmware/drivers/usb-designware.c index 375fd8be74..ab4c6037b5 100644 --- a/firmware/drivers/usb-designware.c +++ b/firmware/drivers/usb-designware.c @@ -1333,7 +1333,7 @@ void usb_drv_release_endpoint(int endpoint) usb_dw_target_enable_irq(); } -int usb_drv_recv(int endpoint, void* ptr, int length) +int usb_drv_recv_nonblocking(int endpoint, void* ptr, int length) { int epnum = EP_NUM(endpoint); struct usb_dw_ep* dw_ep = usb_dw_get_ep(epnum, USB_DW_EPDIR_OUT); |