diff options
| author | Michael Sevakis <jethead71@rockbox.org> | 2017-01-30 09:52:05 -0500 |
|---|---|---|
| committer | Michael Sevakis <jethead71@rockbox.org> | 2017-02-11 22:19:32 -0500 |
| commit | fc9695eb47732e1c189e2f033dbd55e5c346e8c4 (patch) | |
| tree | 550830e9af67f47e3eb87587770b25d22110f57a /apps/gui | |
| parent | 6436c6e749ab04fbd5d97804a6a1c3b3122b326d (diff) | |
Improve radio RDS driver and framework
* Remove unused bits like the radio event and simplify basic
radio interface. It can be more self-contained with rds.h only
required by radio and tuner code.
* Add post-processing to text a-la Silicon Labs AN243. The chip's
error correction can only do so much; additional checks are highly
recommended. Simply testing for two identical messages in a row
is extremely effective and I've never seen corrupted text since
doing that, even with mediocre reception.
Groups segments must arrive in order, not randomly; logic change
only accepts them in order, starting at 0.
Time readout was made a bit better but really we'd need to use
verbose mode and ensure that no errors were seen during receiving
of time and more checks would be need to have a stable PI. The
text is the important bit anyway.
* Time out of stale text.
* Text is no longer updated until a complete group has been
received, as is specified in the standard. Perhaps go back to
scrolling text lines in the radio screen?
* Add proper character conversion to UTF-8. Only the default G0
table for the moment. The other two could be added in.
* Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow
the option for processed RDS data to be pushed to the driver and
still do proper post-processing (only text conversion for now for
the latter).
Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925
Diffstat (limited to 'apps/gui')
| -rw-r--r-- | apps/gui/skin_engine/skin_tokens.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/apps/gui/skin_engine/skin_tokens.c b/apps/gui/skin_engine/skin_tokens.c index c07d4cf2df..cbf732fe10 100644 --- a/apps/gui/skin_engine/skin_tokens.c +++ b/apps/gui/skin_engine/skin_tokens.c @@ -540,9 +540,11 @@ const char *get_radio_token(struct wps_token *token, int preset_offset, #ifdef HAVE_RDS_CAP return "rds"; case SKIN_TOKEN_RDS_NAME: - return tuner_get_rds_info(RADIO_RDS_NAME); + tuner_get_rds_info(RADIO_RDS_NAME, buf, buf_size); + return buf; case SKIN_TOKEN_RDS_TEXT: - return tuner_get_rds_info(RADIO_RDS_TEXT); + tuner_get_rds_info(RADIO_RDS_TEXT, buf, buf_size); + return buf; #else return NULL; /* end of the SKIN_TOKEN_HAVE_RDS case */ #endif /* HAVE_RDS_CAP */ |