summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMax Kellermann <max@musicpd.org>2020-02-01 13:59:55 +0100
committerMax Kellermann <max@musicpd.org>2020-02-01 14:02:43 +0100
commitbc6eca2115d8d333eed61d23a01958926bbd7a9c (patch)
treef817a3c9779566c18157d01595db293dd63a70e1 /src
parent72ec641f0d5a33de882a05a53e2f3a3b74226eb3 (diff)
*: add `explicit`
Diffstat (limited to 'src')
-rw-r--r--src/archive/plugins/Iso9660ArchivePlugin.cxx2
-rw-r--r--src/archive/plugins/ZzipArchivePlugin.cxx2
-rw-r--r--src/db/plugins/upnp/Directory.cxx2
-rw-r--r--src/encoder/plugins/FlacEncoderPlugin.cxx2
-rw-r--r--src/encoder/plugins/LameEncoderPlugin.cxx2
-rw-r--r--src/encoder/plugins/OpusEncoderPlugin.cxx2
-rw-r--r--src/encoder/plugins/ShineEncoderPlugin.cxx2
-rw-r--r--src/encoder/plugins/TwolameEncoderPlugin.cxx2
-rw-r--r--src/encoder/plugins/VorbisEncoderPlugin.cxx2
-rw-r--r--src/encoder/plugins/WaveEncoderPlugin.cxx2
-rw-r--r--src/event/SignalMonitor.cxx2
-rw-r--r--src/filter/plugins/AutoConvertFilterPlugin.cxx2
-rw-r--r--src/filter/plugins/ConvertFilterPlugin.cxx2
-rw-r--r--src/filter/plugins/NormalizeFilterPlugin.cxx2
-rw-r--r--src/filter/plugins/RouteFilterPlugin.cxx2
-rw-r--r--src/input/plugins/AlsaInputPlugin.cxx2
-rw-r--r--src/lib/upnp/Device.cxx2
-rw-r--r--src/mixer/plugins/NullMixerPlugin.cxx2
-rw-r--r--src/mixer/plugins/SoftwareMixerPlugin.cxx2
-rw-r--r--src/neighbor/plugins/SmbclientNeighborPlugin.cxx2
-rw-r--r--src/output/plugins/AoOutputPlugin.cxx2
-rw-r--r--src/output/plugins/FifoOutputPlugin.cxx2
-rw-r--r--src/output/plugins/NullOutputPlugin.cxx2
-rw-r--r--src/output/plugins/OpenALOutputPlugin.cxx2
-rw-r--r--src/output/plugins/PipeOutputPlugin.cxx2
-rw-r--r--src/output/plugins/RecorderOutputPlugin.cxx2
-rw-r--r--src/pcm/PcmFormat.cxx4
-rw-r--r--src/playlist/plugins/CuePlaylistPlugin.cxx2
-rw-r--r--src/playlist/plugins/ExtM3uPlaylistPlugin.cxx2
-rw-r--r--src/playlist/plugins/M3uPlaylistPlugin.cxx2
-rw-r--r--src/storage/plugins/LocalStorage.cxx2
31 files changed, 32 insertions, 32 deletions
diff --git a/src/archive/plugins/Iso9660ArchivePlugin.cxx b/src/archive/plugins/Iso9660ArchivePlugin.cxx
index 2a63b2505..eb76cc228 100644
--- a/src/archive/plugins/Iso9660ArchivePlugin.cxx
+++ b/src/archive/plugins/Iso9660ArchivePlugin.cxx
@@ -62,7 +62,7 @@ class Iso9660ArchiveFile final : public ArchiveFile {
std::shared_ptr<Iso9660> iso;
public:
- Iso9660ArchiveFile(std::shared_ptr<Iso9660> &&_iso)
+ explicit Iso9660ArchiveFile(std::shared_ptr<Iso9660> &&_iso)
:iso(std::move(_iso)) {}
/**
diff --git a/src/archive/plugins/ZzipArchivePlugin.cxx b/src/archive/plugins/ZzipArchivePlugin.cxx
index 7b60ab36f..bb1776379 100644
--- a/src/archive/plugins/ZzipArchivePlugin.cxx
+++ b/src/archive/plugins/ZzipArchivePlugin.cxx
@@ -54,7 +54,7 @@ class ZzipArchiveFile final : public ArchiveFile {
std::shared_ptr<ZzipDir> dir;
public:
- ZzipArchiveFile(std::shared_ptr<ZzipDir> &&_dir)
+ explicit ZzipArchiveFile(std::shared_ptr<ZzipDir> &&_dir)
:dir(std::move(_dir)) {}
void Visit(ArchiveVisitor &visitor) override;
diff --git a/src/db/plugins/upnp/Directory.cxx b/src/db/plugins/upnp/Directory.cxx
index 4678bee00..de344cba3 100644
--- a/src/db/plugins/upnp/Directory.cxx
+++ b/src/db/plugins/upnp/Directory.cxx
@@ -111,7 +111,7 @@ class UPnPDirParser final : public CommonExpatParser {
TagBuilder tag;
public:
- UPnPDirParser(UPnPDirContent &_directory)
+ explicit UPnPDirParser(UPnPDirContent &_directory)
:directory(_directory),
state(NONE),
tag_type(TAG_NUM_OF_ITEM_TYPES)
diff --git a/src/encoder/plugins/FlacEncoderPlugin.cxx b/src/encoder/plugins/FlacEncoderPlugin.cxx
index 6123082e1..a433b6188 100644
--- a/src/encoder/plugins/FlacEncoderPlugin.cxx
+++ b/src/encoder/plugins/FlacEncoderPlugin.cxx
@@ -82,7 +82,7 @@ class PreparedFlacEncoder final : public PreparedEncoder {
const unsigned compression;
public:
- PreparedFlacEncoder(const ConfigBlock &block);
+ explicit PreparedFlacEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format) override;
diff --git a/src/encoder/plugins/LameEncoderPlugin.cxx b/src/encoder/plugins/LameEncoderPlugin.cxx
index 6b06d2ad6..b4b05e81c 100644
--- a/src/encoder/plugins/LameEncoderPlugin.cxx
+++ b/src/encoder/plugins/LameEncoderPlugin.cxx
@@ -57,7 +57,7 @@ class PreparedLameEncoder final : public PreparedEncoder {
int bitrate;
public:
- PreparedLameEncoder(const ConfigBlock &block);
+ explicit PreparedLameEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format) override;
diff --git a/src/encoder/plugins/OpusEncoderPlugin.cxx b/src/encoder/plugins/OpusEncoderPlugin.cxx
index 233f03799..c445feeba 100644
--- a/src/encoder/plugins/OpusEncoderPlugin.cxx
+++ b/src/encoder/plugins/OpusEncoderPlugin.cxx
@@ -79,7 +79,7 @@ class PreparedOpusEncoder final : public PreparedEncoder {
const bool chaining;
public:
- PreparedOpusEncoder(const ConfigBlock &block);
+ explicit PreparedOpusEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format) override;
diff --git a/src/encoder/plugins/ShineEncoderPlugin.cxx b/src/encoder/plugins/ShineEncoderPlugin.cxx
index 93c9c9ed5..6eb7b0a79 100644
--- a/src/encoder/plugins/ShineEncoderPlugin.cxx
+++ b/src/encoder/plugins/ShineEncoderPlugin.cxx
@@ -86,7 +86,7 @@ class PreparedShineEncoder final : public PreparedEncoder {
shine_config_t config;
public:
- PreparedShineEncoder(const ConfigBlock &block);
+ explicit PreparedShineEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format) override;
diff --git a/src/encoder/plugins/TwolameEncoderPlugin.cxx b/src/encoder/plugins/TwolameEncoderPlugin.cxx
index 7952f12c7..6620cdc27 100644
--- a/src/encoder/plugins/TwolameEncoderPlugin.cxx
+++ b/src/encoder/plugins/TwolameEncoderPlugin.cxx
@@ -73,7 +73,7 @@ class PreparedTwolameEncoder final : public PreparedEncoder {
int bitrate;
public:
- PreparedTwolameEncoder(const ConfigBlock &block);
+ explicit PreparedTwolameEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format) override;
diff --git a/src/encoder/plugins/VorbisEncoderPlugin.cxx b/src/encoder/plugins/VorbisEncoderPlugin.cxx
index a213dd781..eb387384b 100644
--- a/src/encoder/plugins/VorbisEncoderPlugin.cxx
+++ b/src/encoder/plugins/VorbisEncoderPlugin.cxx
@@ -65,7 +65,7 @@ class PreparedVorbisEncoder final : public PreparedEncoder {
int bitrate;
public:
- PreparedVorbisEncoder(const ConfigBlock &block);
+ explicit PreparedVorbisEncoder(const ConfigBlock &block);
/* virtual methods from class PreparedEncoder */
Encoder *Open(AudioFormat &audio_format) override;
diff --git a/src/encoder/plugins/WaveEncoderPlugin.cxx b/src/encoder/plugins/WaveEncoderPlugin.cxx
index 77b172990..626972f2f 100644
--- a/src/encoder/plugins/WaveEncoderPlugin.cxx
+++ b/src/encoder/plugins/WaveEncoderPlugin.cxx
@@ -33,7 +33,7 @@ class WaveEncoder final : public Encoder {
DynamicFifoBuffer<uint8_t> buffer;
public:
- WaveEncoder(AudioFormat &audio_format) noexcept;
+ explicit WaveEncoder(AudioFormat &audio_format) noexcept;
/* virtual methods from class Encoder */
void Write(const void *data, size_t length) override;
diff --git a/src/event/SignalMonitor.cxx b/src/event/SignalMonitor.cxx
index 5d2bc7f65..236f19d03 100644
--- a/src/event/SignalMonitor.cxx
+++ b/src/event/SignalMonitor.cxx
@@ -53,7 +53,7 @@ class SignalMonitor final : private SocketMonitor {
#endif
public:
- SignalMonitor(EventLoop &_loop)
+ explicit SignalMonitor(EventLoop &_loop)
:SocketMonitor(_loop) {
#ifndef USE_SIGNALFD
SocketMonitor::Open(SocketDescriptor(fd.Get()));
diff --git a/src/filter/plugins/AutoConvertFilterPlugin.cxx b/src/filter/plugins/AutoConvertFilterPlugin.cxx
index 24f267ce8..cf6786c92 100644
--- a/src/filter/plugins/AutoConvertFilterPlugin.cxx
+++ b/src/filter/plugins/AutoConvertFilterPlugin.cxx
@@ -64,7 +64,7 @@ class PreparedAutoConvertFilter final : public PreparedFilter {
std::unique_ptr<PreparedFilter> filter;
public:
- PreparedAutoConvertFilter(std::unique_ptr<PreparedFilter> _filter) noexcept
+ explicit PreparedAutoConvertFilter(std::unique_ptr<PreparedFilter> _filter) noexcept
:filter(std::move(_filter)) {}
std::unique_ptr<Filter> Open(AudioFormat &af) override;
diff --git a/src/filter/plugins/ConvertFilterPlugin.cxx b/src/filter/plugins/ConvertFilterPlugin.cxx
index 28f35e03a..15c3ae0a6 100644
--- a/src/filter/plugins/ConvertFilterPlugin.cxx
+++ b/src/filter/plugins/ConvertFilterPlugin.cxx
@@ -42,7 +42,7 @@ class ConvertFilter final : public Filter {
std::unique_ptr<PcmConvert> state;
public:
- ConvertFilter(const AudioFormat &audio_format);
+ explicit ConvertFilter(const AudioFormat &audio_format);
void Set(const AudioFormat &_out_audio_format);
diff --git a/src/filter/plugins/NormalizeFilterPlugin.cxx b/src/filter/plugins/NormalizeFilterPlugin.cxx
index a8cf182cd..b4e0b444b 100644
--- a/src/filter/plugins/NormalizeFilterPlugin.cxx
+++ b/src/filter/plugins/NormalizeFilterPlugin.cxx
@@ -34,7 +34,7 @@ class NormalizeFilter final : public Filter {
PcmBuffer buffer;
public:
- NormalizeFilter(const AudioFormat &audio_format)
+ explicit NormalizeFilter(const AudioFormat &audio_format)
:Filter(audio_format), compressor(Compressor_new(0)) {
}
diff --git a/src/filter/plugins/RouteFilterPlugin.cxx b/src/filter/plugins/RouteFilterPlugin.cxx
index 15cf522e3..66fac1e1a 100644
--- a/src/filter/plugins/RouteFilterPlugin.cxx
+++ b/src/filter/plugins/RouteFilterPlugin.cxx
@@ -130,7 +130,7 @@ public:
* @param block the configuration block to read
* @param filter a route_filter whose min_channels and sources[] to set
*/
- PreparedRouteFilter(const ConfigBlock &block);
+ explicit PreparedRouteFilter(const ConfigBlock &block);
/* virtual methods from class PreparedFilter */
std::unique_ptr<Filter> Open(AudioFormat &af) override;
diff --git a/src/input/plugins/AlsaInputPlugin.cxx b/src/input/plugins/AlsaInputPlugin.cxx
index aee525cc6..7b384b3a8 100644
--- a/src/input/plugins/AlsaInputPlugin.cxx
+++ b/src/input/plugins/AlsaInputPlugin.cxx
@@ -139,7 +139,7 @@ class AlsaInputStream::SourceSpec {
DivideString components;
public:
- SourceSpec(const char *_uri)
+ explicit SourceSpec(const char *_uri)
: uri(_uri)
, components(uri, '?')
{
diff --git a/src/lib/upnp/Device.cxx b/src/lib/upnp/Device.cxx
index 23827f025..37a39686d 100644
--- a/src/lib/upnp/Device.cxx
+++ b/src/lib/upnp/Device.cxx
@@ -40,7 +40,7 @@ class UPnPDeviceParser final : public CommonExpatParser {
UPnPService m_tservice;
public:
- UPnPDeviceParser(UPnPDevice& device)
+ explicit UPnPDeviceParser(UPnPDevice& device)
:m_device(device),
value(nullptr) {}
diff --git a/src/mixer/plugins/NullMixerPlugin.cxx b/src/mixer/plugins/NullMixerPlugin.cxx
index 5a5f5f352..4f8989d50 100644
--- a/src/mixer/plugins/NullMixerPlugin.cxx
+++ b/src/mixer/plugins/NullMixerPlugin.cxx
@@ -26,7 +26,7 @@ class NullMixer final : public Mixer {
unsigned volume;
public:
- NullMixer(MixerListener &_listener)
+ explicit NullMixer(MixerListener &_listener)
:Mixer(null_mixer_plugin, _listener),
volume(100)
{
diff --git a/src/mixer/plugins/SoftwareMixerPlugin.cxx b/src/mixer/plugins/SoftwareMixerPlugin.cxx
index a78ddd6f9..c394a9628 100644
--- a/src/mixer/plugins/SoftwareMixerPlugin.cxx
+++ b/src/mixer/plugins/SoftwareMixerPlugin.cxx
@@ -34,7 +34,7 @@ class SoftwareMixer final : public Mixer {
unsigned volume = 100;
public:
- SoftwareMixer(MixerListener &_listener)
+ explicit SoftwareMixer(MixerListener &_listener)
:Mixer(software_mixer_plugin, _listener)
{
}
diff --git a/src/neighbor/plugins/SmbclientNeighborPlugin.cxx b/src/neighbor/plugins/SmbclientNeighborPlugin.cxx
index 2d59d56d1..805799d91 100644
--- a/src/neighbor/plugins/SmbclientNeighborPlugin.cxx
+++ b/src/neighbor/plugins/SmbclientNeighborPlugin.cxx
@@ -66,7 +66,7 @@ class SmbclientNeighborExplorer final : public NeighborExplorer {
bool quit;
public:
- SmbclientNeighborExplorer(NeighborListener &_listener) noexcept
+ explicit SmbclientNeighborExplorer(NeighborListener &_listener) noexcept
:NeighborExplorer(_listener),
thread(BIND_THIS_METHOD(ThreadFunc)) {}
diff --git a/src/output/plugins/AoOutputPlugin.cxx b/src/output/plugins/AoOutputPlugin.cxx
index 187c164b6..ec700d607 100644
--- a/src/output/plugins/AoOutputPlugin.cxx
+++ b/src/output/plugins/AoOutputPlugin.cxx
@@ -52,7 +52,7 @@ class AoOutput final : AudioOutput, SafeSingleton<AoInit> {
size_t frame_size;
- AoOutput(const ConfigBlock &block);
+ explicit AoOutput(const ConfigBlock &block);
~AoOutput() override;
public:
diff --git a/src/output/plugins/FifoOutputPlugin.cxx b/src/output/plugins/FifoOutputPlugin.cxx
index 8e49d7216..4eb6ccafa 100644
--- a/src/output/plugins/FifoOutputPlugin.cxx
+++ b/src/output/plugins/FifoOutputPlugin.cxx
@@ -42,7 +42,7 @@ class FifoOutput final : AudioOutput {
Timer *timer;
public:
- FifoOutput(const ConfigBlock &block);
+ explicit FifoOutput(const ConfigBlock &block);
~FifoOutput() override {
CloseFifo();
diff --git a/src/output/plugins/NullOutputPlugin.cxx b/src/output/plugins/NullOutputPlugin.cxx
index 712dcf6f9..02cd01f91 100644
--- a/src/output/plugins/NullOutputPlugin.cxx
+++ b/src/output/plugins/NullOutputPlugin.cxx
@@ -27,7 +27,7 @@ class NullOutput final : AudioOutput {
Timer *timer;
public:
- NullOutput(const ConfigBlock &block)
+ explicit NullOutput(const ConfigBlock &block)
:AudioOutput(0),
sync(block.GetBlockValue("sync", true)) {}
diff --git a/src/output/plugins/OpenALOutputPlugin.cxx b/src/output/plugins/OpenALOutputPlugin.cxx
index faf6019d0..55c797b6f 100644
--- a/src/output/plugins/OpenALOutputPlugin.cxx
+++ b/src/output/plugins/OpenALOutputPlugin.cxx
@@ -44,7 +44,7 @@ class OpenALOutput final : AudioOutput {
ALenum format;
ALuint frequency;
- OpenALOutput(const ConfigBlock &block);
+ explicit OpenALOutput(const ConfigBlock &block);
public:
static AudioOutput *Create(EventLoop &,
diff --git a/src/output/plugins/PipeOutputPlugin.cxx b/src/output/plugins/PipeOutputPlugin.cxx
index 099bfeb09..62e01be1e 100644
--- a/src/output/plugins/PipeOutputPlugin.cxx
+++ b/src/output/plugins/PipeOutputPlugin.cxx
@@ -30,7 +30,7 @@ class PipeOutput final : AudioOutput {
const std::string cmd;
FILE *fh;
- PipeOutput(const ConfigBlock &block);
+ explicit PipeOutput(const ConfigBlock &block);
public:
static AudioOutput *Create(EventLoop &,
diff --git a/src/output/plugins/RecorderOutputPlugin.cxx b/src/output/plugins/RecorderOutputPlugin.cxx
index 77fd709a5..590ecec58 100644
--- a/src/output/plugins/RecorderOutputPlugin.cxx
+++ b/src/output/plugins/RecorderOutputPlugin.cxx
@@ -67,7 +67,7 @@ class RecorderOutput final : AudioOutput {
*/
FileOutputStream *file;
- RecorderOutput(const ConfigBlock &block);
+ explicit RecorderOutput(const ConfigBlock &block);
public:
static AudioOutput *Create(EventLoop &, const ConfigBlock &block) {
diff --git a/src/pcm/PcmFormat.cxx b/src/pcm/PcmFormat.cxx
index 943438790..5aa28db26 100644
--- a/src/pcm/PcmFormat.cxx
+++ b/src/pcm/PcmFormat.cxx
@@ -53,7 +53,7 @@ struct Convert24To16 {
PcmDither &dither;
- Convert24To16(PcmDither &_dither):dither(_dither) {}
+ explicit Convert24To16(PcmDither &_dither):dither(_dither) {}
void Convert(int16_t *out, const int32_t *in, size_t n) {
dither.Dither24To16(out, in, in + n);
@@ -66,7 +66,7 @@ struct Convert32To16 {
PcmDither &dither;
- Convert32To16(PcmDither &_dither):dither(_dither) {}
+ explicit Convert32To16(PcmDither &_dither):dither(_dither) {}
void Convert(int16_t *out, const int32_t *in, size_t n) {
dither.Dither32To16(out, in, in + n);
diff --git a/src/playlist/plugins/CuePlaylistPlugin.cxx b/src/playlist/plugins/CuePlaylistPlugin.cxx
index 3740b231b..d263e0190 100644
--- a/src/playlist/plugins/CuePlaylistPlugin.cxx
+++ b/src/playlist/plugins/CuePlaylistPlugin.cxx
@@ -28,7 +28,7 @@ class CuePlaylist final : public SongEnumerator {
CueParser parser;
public:
- CuePlaylist(InputStreamPtr &&is)
+ explicit CuePlaylist(InputStreamPtr &&is)
:tis(std::move(is)) {
}
diff --git a/src/playlist/plugins/ExtM3uPlaylistPlugin.cxx b/src/playlist/plugins/ExtM3uPlaylistPlugin.cxx
index 447d01852..0088c0d13 100644
--- a/src/playlist/plugins/ExtM3uPlaylistPlugin.cxx
+++ b/src/playlist/plugins/ExtM3uPlaylistPlugin.cxx
@@ -35,7 +35,7 @@ class ExtM3uPlaylist final : public SongEnumerator {
TextInputStream tis;
public:
- ExtM3uPlaylist(InputStreamPtr &&is)
+ explicit ExtM3uPlaylist(InputStreamPtr &&is)
:tis(std::move(is)) {
}
diff --git a/src/playlist/plugins/M3uPlaylistPlugin.cxx b/src/playlist/plugins/M3uPlaylistPlugin.cxx
index a5d5c77e1..6f4b34f92 100644
--- a/src/playlist/plugins/M3uPlaylistPlugin.cxx
+++ b/src/playlist/plugins/M3uPlaylistPlugin.cxx
@@ -28,7 +28,7 @@ class M3uPlaylist final : public SongEnumerator {
TextInputStream tis;
public:
- M3uPlaylist(InputStreamPtr &&is)
+ explicit M3uPlaylist(InputStreamPtr &&is)
:tis(std::move(is)) {
}
diff --git a/src/storage/plugins/LocalStorage.cxx b/src/storage/plugins/LocalStorage.cxx
index eac054745..2663c63ef 100644
--- a/src/storage/plugins/LocalStorage.cxx
+++ b/src/storage/plugins/LocalStorage.cxx
@@ -36,7 +36,7 @@ class LocalDirectoryReader final : public StorageDirectoryReader {
std::string name_utf8;
public:
- LocalDirectoryReader(AllocatedPath &&_base_fs)
+ explicit LocalDirectoryReader(AllocatedPath &&_base_fs)
:base_fs(std::move(_base_fs)), reader(base_fs) {}
/* virtual methods from class StorageDirectoryReader */