eliminate g_error() usage

Replaced all occurrences of g_error() with MPD_ERROR() located in a new header
file 'mpd_error.h'. This macro uses g_critical() to print the error message
and then exits gracefully in contrast to g_error() which would internally call
abort() to produce a core dump.

The macro name is distinctive and allows to find all places with dubious error
handling. The long-term goal is to get rid of MPD_ERROR() altogether. To
facilitate the eventual removal of this macro it was added in a new header
file rather than to an existing header file.

This fixes #2995 and #3007.

1 files changed, 3 insertions, 2 deletions

diff --git a/src/tag.c b/src/tag.c
index aa96a468f..6ce46a831 100644
--- a/src/tag.c
+++ b/src/tag.c
@@ -23,6 +23,7 @@
 #include "tag_pool.h"
 #include "conf.h"
 #include "song.h"
+#include "mpd_error.h"
 
 #include <glib.h>
 #include <assert.h>
@@ -138,8 +139,8 @@ void tag_lib_init(void)
 
 			type = tag_name_parse_i(c);
 			if (type == TAG_NUM_OF_ITEM_TYPES)
-				g_error("error parsing metadata item \"%s\"",
-					c);
+				MPD_ERROR("error parsing metadata item \"%s\"",
+					  c);
 
 			ignore_tag_items[type] = false;