diff options
author | Rosen Penev <rosenp@gmail.com> | 2020-01-31 19:37:53 -0800 |
---|---|---|
committer | Rosen Penev <rosenp@gmail.com> | 2020-01-31 21:27:26 -0800 |
commit | b64fdae938871976f0fdb6ab0d1a6f623ae9cd64 (patch) | |
tree | f14661c6749632066cbf33c095c633a2128f4fd6 /src/filter | |
parent | 0b2444450f1dd3e249529d14418abf89579ad09a (diff) |
[clang-tidy] use override instead of virtual
Found with modernize-use-override
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Diffstat (limited to 'src/filter')
-rw-r--r-- | src/filter/NullFilter.hxx | 2 | ||||
-rw-r--r-- | src/filter/Observer.cxx | 4 | ||||
-rw-r--r-- | src/filter/plugins/NormalizeFilterPlugin.cxx | 2 | ||||
-rw-r--r-- | src/filter/plugins/NullFilterPlugin.cxx | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/src/filter/NullFilter.hxx b/src/filter/NullFilter.hxx index ad4579e58..01cb7b012 100644 --- a/src/filter/NullFilter.hxx +++ b/src/filter/NullFilter.hxx @@ -27,7 +27,7 @@ class NullFilter final : public Filter { public: explicit NullFilter(const AudioFormat &af):Filter(af) {} - virtual ConstBuffer<void> FilterPCM(ConstBuffer<void> src) override { + ConstBuffer<void> FilterPCM(ConstBuffer<void> src) override { return src; } }; diff --git a/src/filter/Observer.cxx b/src/filter/Observer.cxx index 53282ef3e..364c7b958 100644 --- a/src/filter/Observer.cxx +++ b/src/filter/Observer.cxx @@ -36,7 +36,7 @@ public: :observer(_observer), prepared_filter(std::move(_prepared_filter)) {} - ~PreparedProxy() noexcept { + ~PreparedProxy() noexcept override { assert(child == nullptr); assert(observer.proxy == this); @@ -63,7 +63,7 @@ public: :Filter(_filter->GetOutAudioFormat()), parent(_parent), filter(std::move(_filter)) {} - ~Proxy() noexcept { + ~Proxy() noexcept override { parent.Clear(this); } diff --git a/src/filter/plugins/NormalizeFilterPlugin.cxx b/src/filter/plugins/NormalizeFilterPlugin.cxx index 729eaa9bd..bd315c91b 100644 --- a/src/filter/plugins/NormalizeFilterPlugin.cxx +++ b/src/filter/plugins/NormalizeFilterPlugin.cxx @@ -38,7 +38,7 @@ public: :Filter(audio_format), compressor(Compressor_new(0)) { } - ~NormalizeFilter() { + ~NormalizeFilter() override { Compressor_delete(compressor); } diff --git a/src/filter/plugins/NullFilterPlugin.cxx b/src/filter/plugins/NullFilterPlugin.cxx index c3cb646b3..115124179 100644 --- a/src/filter/plugins/NullFilterPlugin.cxx +++ b/src/filter/plugins/NullFilterPlugin.cxx @@ -32,7 +32,7 @@ class PreparedNullFilter final : public PreparedFilter { public: - virtual std::unique_ptr<Filter> Open(AudioFormat &af) override { + std::unique_ptr<Filter> Open(AudioFormat &af) override { return std::make_unique<NullFilter>(af); } }; |