diff options
| author | Rosen Penev <rosenp@gmail.com> | 2020-01-31 19:59:48 -0800 |
|---|---|---|
| committer | Rosen Penev <rosenp@gmail.com> | 2020-02-01 19:53:44 -0800 |
| commit | ecad6d936adcecd6e094dc2054d2d32e6aeea141 (patch) | |
| tree | f45e8dbf84e39ded65ce1f40cabaaae4ef15f672 /src/archive | |
| parent | bc6eca2115d8d333eed61d23a01958926bbd7a9c (diff) | |
[clang-tidy] pass by value where appropriate
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Diffstat (limited to 'src/archive')
| -rw-r--r-- | src/archive/plugins/Bzip2ArchivePlugin.cxx | 7 | ||||
| -rw-r--r-- | src/archive/plugins/Iso9660ArchivePlugin.cxx | 6 |
2 files changed, 8 insertions, 5 deletions
diff --git a/src/archive/plugins/Bzip2ArchivePlugin.cxx b/src/archive/plugins/Bzip2ArchivePlugin.cxx index 79c0bf138..1443b1f60 100644 --- a/src/archive/plugins/Bzip2ArchivePlugin.cxx +++ b/src/archive/plugins/Bzip2ArchivePlugin.cxx @@ -32,6 +32,7 @@ #include <bzlib.h> #include <stdexcept> +#include <utility> class Bzip2ArchiveFile final : public ArchiveFile { std::string name; @@ -65,7 +66,7 @@ class Bzip2InputStream final : public InputStream { char buffer[5000]; public: - Bzip2InputStream(const std::shared_ptr<InputStream> &_input, + Bzip2InputStream(std::shared_ptr<InputStream> _input, const char *uri, Mutex &mutex); ~Bzip2InputStream() override; @@ -111,11 +112,11 @@ bz2_open(Path pathname) /* single archive handling */ -Bzip2InputStream::Bzip2InputStream(const std::shared_ptr<InputStream> &_input, +Bzip2InputStream::Bzip2InputStream(std::shared_ptr<InputStream> _input, const char *_uri, Mutex &_mutex) :InputStream(_uri, _mutex), - input(_input) + input(std::move(_input)) { Open(); } diff --git a/src/archive/plugins/Iso9660ArchivePlugin.cxx b/src/archive/plugins/Iso9660ArchivePlugin.cxx index eb76cc228..8e698ae4d 100644 --- a/src/archive/plugins/Iso9660ArchivePlugin.cxx +++ b/src/archive/plugins/Iso9660ArchivePlugin.cxx @@ -34,6 +34,8 @@ #include <stdlib.h> #include <string.h> +#include <utility> + #define CEILING(x, y) ((x+(y-1))/y) struct Iso9660 { @@ -141,12 +143,12 @@ class Iso9660InputStream final : public InputStream { iso9660_stat_t *statbuf; public: - Iso9660InputStream(const std::shared_ptr<Iso9660> &_iso, + Iso9660InputStream(std::shared_ptr<Iso9660> _iso, const char *_uri, Mutex &_mutex, iso9660_stat_t *_statbuf) :InputStream(_uri, _mutex), - iso(_iso), statbuf(_statbuf) { + iso(std::move(_iso)), statbuf(_statbuf) { size = statbuf->size; seekable = true; SetReady(); |