summaryrefslogtreecommitdiff
path: root/usr/initramfs_data.S
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2020-06-07 16:53:49 +0100
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2020-07-05 14:22:48 +0100
commit838e00b13bfd4cac8b24df25bfc58e2eb99bcc70 (patch)
tree0f4c5e914b529dfc9b64bc849bb9528dd8c495ec /usr/initramfs_data.S
parente9c6004eef0019375e4b0339f1f88d9d6ed99018 (diff)
iio:magnetometer:ak8974: Fix alignment and data leak issues
One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses an array of smaller elements on the stack. As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable structure in the iio_priv() data. This data is allocated with kzalloc so no data can leak appart from previous readings. Fixes: 7c94a8b2ee8cf ("iio: magn: add a driver for AK8974") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: <Stable@vger.kernel.org>
Diffstat (limited to 'usr/initramfs_data.S')
0 files changed, 0 insertions, 0 deletions