summaryrefslogtreecommitdiff
path: root/tools/objtool
diff options
context:
space:
mode:
authorErez Shitrit <erezsh@mellanox.com>2017-11-14 14:51:53 +0200
committerJason Gunthorpe <jgg@mellanox.com>2017-12-18 15:37:05 -0700
commit439000892ee17a9c92f1e4297818790ef8bb4ced (patch)
treea405e00bffb88f9d4e483bc735cf7870e973a4ff /tools/objtool
parentd7c0557a10eeff5177deb3c1733383b139e1fcae (diff)
IB/ipoib: Avoid memory leak if the SA returns a different DGID
The ipoib path database is organized around DGIDs from the LLADDR, but the SA is free to return a different GID when asked for path. This causes a bug because the SA's modified DGID is copied into the database key, even though it is no longer the correct lookup key, causing a memory leak and other malfunctions. Ensure the database key does not change after the SA query completes. Demonstration of the bug is as follows ipoib wants to send to GID fe80:0000:0000:0000:0002:c903:00ef:5ee2, it creates new record in the DB with that gid as a key, and issues a new request to the SM. Now, the SM from some reason returns path-record with other SGID (for example, 2001:0000:0000:0000:0002:c903:00ef:5ee2 that contains the local subnet prefix) now ipoib will overwrite the current entry with the new one, and if new request to the original GID arrives ipoib will not find it in the DB (was overwritten) and will create new record that in its turn will also be overwritten by the response from the SM, and so on till the driver eats all the device memory. Signed-off-by: Erez Shitrit <erezsh@mellanox.com> Signed-off-by: Leon Romanovsky <leon@kernel.org> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'tools/objtool')
0 files changed, 0 insertions, 0 deletions