summaryrefslogtreecommitdiff
path: root/tools/debugging
diff options
context:
space:
mode:
authorJiri Olsa <jolsa@kernel.org>2020-05-20 09:40:50 +0200
committerArnaldo Carvalho de Melo <acme@redhat.com>2020-05-28 10:03:27 -0300
commitae7626418d71ae551fd1f0a85ae7ad9d8b2d4f28 (patch)
tree14080aa52983c9b7689b840a4293ea44c7adc207 /tools/debugging
parent498ef715a00bb87ca65a89e7893c644499bb309c (diff)
perf stat: Fail on extra comma while parsing events
Ian reported that we allow to parse following: $ perf stat -e ,cycles true which is wrong and we should fail, like we do with this fix: $ perf stat -e ,cycles true event syntax error: ',cycles' \___ parser error The reason is that we don't have rule for ',' in 'event' start condition and it's matched and accepted by default rule. Add scanner debug support (that Ian already added for expr code), which was really useful for finding this. It's enabled together with bison debug via 'make PARSER_DEBUG=1'. Reported-by: Ian Rogers <irogers@google.com> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Acked-by: Ian Rogers <irogers@google.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Michael Petlan <mpetlan@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lore.kernel.org/lkml/20200520074050.156988-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/debugging')
0 files changed, 0 insertions, 0 deletions