diff options
author | Tejun Heo <htejun@gmail.com> | 2011-01-20 13:59:06 +0100 |
---|---|---|
committer | Jeff Garzik <jgarzik@redhat.com> | 2011-01-28 03:16:20 -0500 |
commit | 729a6a300e628a48cf12bac93a964a535e83cd1d (patch) | |
tree | 716472edea8c210c4f498c742c3c9ea21d546469 /sound/core/sgbuf.c | |
parent | 4a5610a04d415ed94af75bb1159d2621d62c8328 (diff) |
libata: set queue DMA alignment to sector size for ATAPI too
ata_pio_sectors() expects buffer for each sector to be contained in a
single page; otherwise, it ends up overrunning the first page. This
is achieved by setting queue DMA alignment. If sector_size is smaller
than PAGE_SIZE and all buffers are sector_size aligned, buffer for
each sector is always contained in a single page.
This wasn't applied to ATAPI devices but IDENTIFY_PACKET is executed
as ATA_PROT_PIO and thus uses ata_pio_sectors(). Newer versions of
udev issue IDENTIFY_PACKET with unaligned buffer triggering the
problem and causing oops.
This patch fixes the problem by setting sdev->sector_size to
ATA_SECT_SIZE on ATATPI devices and always setting DMA alignment to
sector_size. While at it, add a warning for the unlikely but still
possible scenario where sector_size is larger than PAGE_SIZE, in which
case the alignment wouldn't be enough.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: John Stanley <jpsinthemix@verizon.net>
Tested-by: John Stanley <jpsinthemix@verizon.net>
Cc: stable@kernel.org
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'sound/core/sgbuf.c')
0 files changed, 0 insertions, 0 deletions