summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorAmir Goldstein <amir73il@gmail.com>2018-10-08 07:25:23 +0300
committerMiklos Szeredi <mszeredi@redhat.com>2018-10-26 23:34:39 +0200
commitb10cdcdc2012b2c199077a0a648e8a7067e573bf (patch)
tree1198b90b01c4cc718e4ef9c3257824bbf511dd10 /security
parent007ea44892e6fa963a0876a979e34890325c64eb (diff)
ovl: untangle copy up call chain
In an attempt to dedup ~100 LOC, we ended up creating a tangled call chain, whose branches merge and diverge in several points according to the immutable c->tmpfile copy up mode. This call chain was hard to analyse for locking correctness because the locking requirements for the c->tmpfile flow were very different from the locking requirements for the !c->tmpfile flow (i.e. directory vs. regulare file copy up). Split the copy up helpers of the c->tmpfile flow from those of the !c->tmpfile (i.e. workdir) flow and remove the c->tmpfile mode from copy up context. Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions