diff options
author | J. Bruce Fields <bfields@redhat.com> | 2020-07-17 18:54:54 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@redhat.com> | 2020-09-25 18:02:02 -0400 |
commit | ae3c57b5ca47665dc3416447a5534a9796096d86 (patch) | |
tree | 9fda3211dbfb66ba2a43d7145e9405d2ea237510 /security/Makefile | |
parent | 0aa99c4d1f216318b1c4f4e4fe321868294a1d9f (diff) |
nfsd: Cache R, RW, and W opens separately
The nfsd open code has always kept separate read-only, read-write, and
write-only opens as necessary to ensure that when a client closes or
downgrades, we don't retain more access than necessary.
Also, I didn't realize the cache behaved this way when I wrote
94415b06eb8a "nfsd4: a client's own opens needn't prevent delegations".
There I assumed fi_fds[O_WRONLY] and fi_fds[O_RDWR] would always be
distinct. The violation of that assumption is triggering a
WARN_ON_ONCE() and could also cause the server to give out a delegation
when it shouldn't.
Fixes: 94415b06eb8a ("nfsd4: a client's own opens needn't prevent delegations")
Tested-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'security/Makefile')
0 files changed, 0 insertions, 0 deletions