diff options
| author | Daniel Ritz <daniel.ritz-ml@swissonline.ch> | 2006-06-27 18:40:54 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-06-27 18:36:39 -0700 |
| commit | d6fcb3b9cf776e3f748709cd3091a72cb3855c29 (patch) | |
| tree | 1b60436804d31c9500662e3b84f4b33a0d9dac6d /scripts/basic | |
| parent | f17a2686b11453680e9662ef8bdc8d948d0dce18 (diff) | |
[PATCH] i2c-i801.c: don't pci_disable_device() after it was just enabled
Commit 02dd7ae2892e5ceff111d032769c78d3377df970 ("[PATCH] i2c-i801:
Merge setup function") has a missing return 0 in the _probe() function.
This means the error path is always executed and pci_disable_device() is
called even when the device just got successfully enabled.
Having the SMBus device disabled makes some systems (eg.
Fujitsu-Siemens Lifebook E8010) hang hard during power-off.
Intead of reverting the whole commit this patch fixes it up:
- don't ever call pci_disable_device(), also not in the _remove() function
to avoid hangs
- fix missing pci_release_region() in error path
Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'scripts/basic')
0 files changed, 0 insertions, 0 deletions