diff options
author | Eric Dumazet <edumazet@google.com> | 2020-04-30 10:35:42 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-04-30 13:24:01 -0700 |
commit | ccd0628fca440268711560a1dbacc727b4f9e214 (patch) | |
tree | 83a814f124b01ec4c0c343d97c2ceb1e46854733 /net/ipv4/tcp_htcp.c | |
parent | 2b195850128f5bafde177b12489d9fa27962cc1e (diff) |
tcp: tcp_sack_new_ofo_skb() should be more conservative
Currently, tcp_sack_new_ofo_skb() sends an ack if prior
acks were 'compressed', if room has to be made in tp->selective_acks[]
But there is no guarantee all four sack ranges can be included
in SACK option. As a matter of fact, when TCP timestamps option
is used, only three SACK ranges can be included.
Lets assume only two ranges can be included, and force the ack:
- When we touch more than 2 ranges in the reordering
done if tcp_sack_extend() could be done.
- If we have at least 2 ranges when adding a new one.
This enforces that before a range is in third or fourth
position, at least one ACK packet included it in first/second
position.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_htcp.c')
0 files changed, 0 insertions, 0 deletions