summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>2015-03-18 08:17:14 +0200
committerPeter Huewe <peterhuewe@gmx.de>2015-03-18 22:43:05 +0100
commit34d47b6322087665be33ca3aa81775b143a4d7ac (patch)
tree09dbec71809f26be149057226988a07f713c2639 /mm
parentd972b0523fa99358b2a0bafd85fe913b5d4b150a (diff)
tpm: fix: sanitized code paths in tpm_chip_register()
I started to work with PPI interface so that it would be available under character device sysfs directory and realized that chip registeration was still too messy. In TPM 1.x in some rare scenarios (errors that almost never occur) wrong order in deinitialization steps was taken in teardown. I reproduced these scenarios by manually inserting error codes in the place of the corresponding function calls. The key problem is that the teardown is messy with two separate code paths (this was inherited when moving code from tpm-interface.c). Moved TPM 1.x specific register/unregister functionality to own helper functions and added single code path for teardown in tpm_chip_register(). Now the code paths have been fixed and it should be easier to review later on this part of the code. Cc: <stable@vger.kernel.org> Fixes: 7a1d7e6dd76a ("tpm: TPM 2.0 baseline support") Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Scot Doyle <lkml14@scotdoyle.com> Reviewed-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions