diff options
author | Josef Bacik <josef@toxicpanda.com> | 2021-01-14 14:02:42 -0500 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2021-02-08 22:58:55 +0100 |
commit | c78a10aebb275c38d0cfccae129a803fe622e305 (patch) | |
tree | e918544f2ba05e4a22567118e4ac35836a5bc27d /lib/objagg.c | |
parent | 2e626e5673c2a3b4ce8200b961e28edd613ab6a9 (diff) |
btrfs: fix reloc root leak with 0 ref reloc roots on recovery
When recovering a relocation, if we run into a reloc root that has 0
refs we simply add it to the reloc_control->reloc_roots list, and then
clean it up later. The problem with this is __del_reloc_root() doesn't
do anything if the root isn't in the radix tree, which in this case it
won't be because we never call __add_reloc_root() on the reloc_root.
This exit condition simply isn't correct really. During normal
operation we can remove ourselves from the rb tree and then we're meant
to clean up later at merge_reloc_roots() time, and this happens
correctly. During recovery we're depending on free_reloc_roots() to
drop our references, but we're short-circuiting.
Fix this by continuing to check if we're on the list and dropping
ourselves from the reloc_control root list and dropping our reference
appropriately. Change the corresponding BUG_ON() to an ASSERT() that
does the correct thing if we aren't in the rb tree.
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'lib/objagg.c')
0 files changed, 0 insertions, 0 deletions