diff options
author | Mateusz Nosek <mateusznosek0@gmail.com> | 2020-09-27 02:08:58 +0200 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2020-10-28 15:48:51 +0100 |
commit | 921c7ebd1337d1a46783d7e15a850e12aed2eaa0 (patch) | |
tree | 9b4401cb0791023cb74c27a94633ccbf7691d1cf /kernel/softirq.c | |
parent | f8e48a3dca060e80f672d398d181db1298fbc86c (diff) |
futex: Fix incorrect should_fail_futex() handling
If should_futex_fail() returns true in futex_wake_pi(), then the 'ret'
variable is set to -EFAULT and then immediately overwritten. So the failure
injection is non-functional.
Fix it by actually leaving the function and returning -EFAULT.
The Fixes tag is kinda blury because the initial commit which introduced
failure injection was already sloppy, but the below mentioned commit broke
it completely.
[ tglx: Massaged changelog ]
Fixes: 6b4f4bc9cb22 ("locking/futex: Allow low-level atomic operations to return -EAGAIN")
Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20200927000858.24219-1-mateusznosek0@gmail.com
Diffstat (limited to 'kernel/softirq.c')
0 files changed, 0 insertions, 0 deletions