diff options
author | David Howells <dhowells@redhat.com> | 2012-05-21 12:32:13 +0100 |
---|---|---|
committer | James Morris <james.l.morris@oracle.com> | 2012-05-25 20:51:42 +1000 |
commit | 423b9788023263364ea5de04189f02bd9b6a12db (patch) | |
tree | fc3ee4814aa8322fb2abb01c50d96568aa51bd9b /kernel/cred.c | |
parent | ff2bb047c4bce9742e94911eeb44b4d6ff4734ab (diff) |
KEYS: Fix some sparse warnings
Fix some sparse warnings in the keyrings code:
(1) compat_keyctl_instantiate_key_iov() should be static.
(2) There were a couple of places where a pointer was being compared against
integer 0 rather than NULL.
(3) keyctl_instantiate_key_common() should not take a __user-labelled iovec
pointer as the caller must have copied the iovec to kernel space.
(4) __key_link_begin() takes and __key_link_end() releases
keyring_serialise_link_sem under some circumstances and so this should be
declared.
Note that adding __acquires() and __releases() for this doesn't help cure
the warnings messages - something only commenting out both helps.
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Diffstat (limited to 'kernel/cred.c')
0 files changed, 0 insertions, 0 deletions