diff options
author | Josef Bacik <josef@toxicpanda.com> | 2020-08-10 17:31:16 -0400 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2020-08-21 12:20:01 +0200 |
commit | fb2fecbad50964b9f27a3b182e74e437b40753ef (patch) | |
tree | 2efd22fc10d9d3a57c42ab1846de39735dbb796a /init | |
parent | bbc37d6e475eee8ffa2156ec813efc6bbb43c06d (diff) |
btrfs: check the right error variable in btrfs_del_dir_entries_in_log
With my new locking code dbench is so much faster that I tripped over a
transaction abort from ENOSPC. This turned out to be because
btrfs_del_dir_entries_in_log was checking for ret == -ENOSPC, but this
function sets err on error, and returns err. So instead of properly
marking the inode as needing a full commit, we were returning -ENOSPC
and aborting in __btrfs_unlink_inode. Fix this by checking the proper
variable so that we return the correct thing in the case of ENOSPC.
The ENOENT needs to be checked, because btrfs_lookup_dir_item_index()
can return -ENOENT if the dir item isn't in the tree log (which would
happen if we hadn't fsync'ed this guy). We actually handle that case in
__btrfs_unlink_inode, so it's an expected error to get back.
Fixes: 4a500fd178c8 ("Btrfs: Metadata ENOSPC handling for tree log")
CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
[ add note and comment about ENOENT ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions