diff options
author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-04-25 21:06:25 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-04-27 11:20:30 -0700 |
commit | 4becb7ee5b3d2829ed7b9261a245a77d5b7de902 (patch) | |
tree | 4787f195bcdbb76ec58114be47c1cf90107f81e6 /include | |
parent | 095f5614bfe16e5b3e191b34ea41b10d6fdd4ced (diff) |
net/x25: Fix x25_neigh refcnt leak when x25 disconnect
x25_connect() invokes x25_get_neigh(), which returns a reference of the
specified x25_neigh object to "x25->neighbour" with increased refcnt.
When x25 connect success and returns, the reference still be hold by
"x25->neighbour", so the refcount should be decreased in
x25_disconnect() to keep refcount balanced.
The reference counting issue happens in x25_disconnect(), which forgets
to decrease the refcnt increased by x25_get_neigh() in x25_connect(),
causing a refcnt leak.
Fix this issue by calling x25_neigh_put() before x25_disconnect()
returns.
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions