diff options
| author | Mike Marciniszyn <mike.marciniszyn@intel.com> | 2016-06-22 13:29:33 -0700 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2016-06-23 10:16:15 -0400 |
| commit | c755f4afa66ad3ed98870bd3254f37c47fb2c800 (patch) | |
| tree | a395969f595da0bcc305d2b4400a7462402832bc /include/rdma/rdma_vt.h | |
| parent | 8ae84f7c56044ee17ef6b700cb34d11ad9428a2e (diff) | |
IB/rdmavt: Correct qp_priv_alloc() return value test
The current drivers return errors from this calldown
wrapped in an ERR_PTR().
The rdmavt code incorrectly tests for NULL.
The code is fixed to use IS_ERR() and change ret according
to the driver return value.
Cc: Stable <stable@vger.kernel.org> # 4.6+
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'include/rdma/rdma_vt.h')
| -rw-r--r-- | include/rdma/rdma_vt.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/rdma/rdma_vt.h b/include/rdma/rdma_vt.h index 16274e2133cd..9c9a27d42aaa 100644 --- a/include/rdma/rdma_vt.h +++ b/include/rdma/rdma_vt.h @@ -203,7 +203,9 @@ struct rvt_driver_provided { /* * Allocate a private queue pair data structure for driver specific - * information which is opaque to rdmavt. + * information which is opaque to rdmavt. Errors are returned via + * ERR_PTR(err). The driver is free to return NULL or a valid + * pointer. */ void * (*qp_priv_alloc)(struct rvt_dev_info *rdi, struct rvt_qp *qp, gfp_t gfp); |