diff options
author | Herbert Xu <herbert@gondor.apana.org.au> | 2009-06-03 21:20:51 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-06-03 21:20:51 -0700 |
commit | 278b2513f76161a9cf1ebddd620dc9d1714fe573 (patch) | |
tree | 948c51313b36b155fe435807ad89a8a76441e7d7 /include/linux/phantom.h | |
parent | 56c8f140719e6f62836fb645d3fd96c6289907fb (diff) |
gso: Stop fraglists from escaping
As it stands skb fraglists can get past the check in dev_queue_xmit
if the skb is marked as GSO. In particular, if the packet doesn't
have the proper checksums for GSO, but can otherwise be handled by
the underlying device, we will not perform the fraglist check on it
at all.
If the underlying device cannot handle fraglists, then this will
break.
The fix is as simple as moving the fraglist check from the device
check into skb_gso_ok.
This has caused crashes with Xen when used together with GRO which
can generate GSO packets with fraglists.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/phantom.h')
0 files changed, 0 insertions, 0 deletions