diff options
| author | yangerkun <yangerkun@huawei.com> | 2020-06-01 15:34:04 +0800 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-06-11 10:59:38 -0400 |
| commit | 5adaccac46ea79008d7b75f47913f1a00f91d0ce (patch) | |
| tree | 59e1ae301608839f2b9083abf22b1bf662d5eac0 /fs | |
| parent | cfb3c85a600c6aa25a2581b3c1c4db3460f14e46 (diff) | |
ext4: stop overwrite the errcode in ext4_setup_super
Now the errcode from ext4_commit_super will overwrite EROFS exists in
ext4_setup_super. Actually, no need to call ext4_commit_super since we
will return EROFS. Fix it by goto done directly.
Fixes: c89128a00838 ("ext4: handle errors on ext4_commit_super")
Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200601073404.3712492-1-yangerkun@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext4/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index edf06c1bee9d..127b8efa8d54 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2412,6 +2412,7 @@ static int ext4_setup_super(struct super_block *sb, struct ext4_super_block *es, ext4_msg(sb, KERN_ERR, "revision level too high, " "forcing read-only mode"); err = -EROFS; + goto done; } if (read_only) goto done; |