diff options
author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-04-25 21:10:23 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-04-27 11:22:38 -0700 |
commit | 62b4011fa7bef9fa00a6aeec26e69685dc1cc21e (patch) | |
tree | 2da8358a87aa37f0b3b8ea2a7c65a0370c669063 /fs/notify | |
parent | 4becb7ee5b3d2829ed7b9261a245a77d5b7de902 (diff) |
net/tls: Fix sk_psock refcnt leak when in tls_data_ready()
tls_data_ready() invokes sk_psock_get(), which returns a reference of
the specified sk_psock object to "psock" with increased refcnt.
When tls_data_ready() returns, local variable "psock" becomes invalid,
so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of
tls_data_ready(). When "psock->ingress_msg" is empty but "psock" is not
NULL, the function forgets to decrease the refcnt increased by
sk_psock_get(), causing a refcnt leak.
Fix this issue by calling sk_psock_put() on all paths when "psock" is
not NULL.
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/notify')
0 files changed, 0 insertions, 0 deletions