diff options
author | Roman Anasal <roman.anasal@bdsu.de> | 2021-01-25 20:43:25 +0100 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2021-02-08 22:58:57 +0100 |
commit | 8898038309876e5b8e535eac9d4b9fe4e3d6f5b3 (patch) | |
tree | 61f11df736b38fa35f72e1787efe83c45b996e19 /fs/jffs2/xattr.c | |
parent | 488bc2a2d21e5faf14f9f695bb592ae9dd0e7465 (diff) |
btrfs: send: use struct send_ctx *sctx for btrfs_compare_trees and changed_cb
btrfs_compare_trees and changed_cb use a void *ctx parameter instead of
struct send_ctx *sctx but when used in changed_cb it is immediately
cast to `struct send_ctx *sctx = ctx;`.
changed_cb is only ever called from btrfs_compare_trees and full_send_tree:
- full_send_tree already passes a struct send_ctx *sctx
- btrfs_compare_trees is only called by send_subvol with a struct send_ctx *sctx
- void *ctx in btrfs_compare_trees is only used to be passed to changed_cb
So casting to/from void *ctx seems unnecessary and directly using
struct send_ctx *sctx instead provides better type-safety.
The original reason for using void *ctx in the first place seems to have
been dropped with 1b51d6fce45e ("btrfs: send: remove indirect callback
parameter for changed_cb").
Signed-off-by: Roman Anasal <roman.anasal@bdsu.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/jffs2/xattr.c')
0 files changed, 0 insertions, 0 deletions