diff options
author | Andrea Arcangeli <aarcange@redhat.com> | 2019-08-05 10:34:04 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-08-05 20:34:11 +0200 |
commit | cc798c83898ea0a77fcaa1a92afda35c3c3ded74 (patch) | |
tree | 8e292bb12576c6411fd06256d9c1df25f0a6fe96 /fs/dlm/lowcomms.c | |
parent | ac43432cb1f5c2950408534987e57c2071e24d8f (diff) |
kernfs: fix memleak in kernel_ops_readdir()
If getdents64 is killed or hits on segfault, it'll leave cgroups
directories in sysfs pinned leaking memory because the kernfs node
won't be freed on rmdir and the parent neither.
Repro:
# for i in `seq 1000`; do mkdir $i; done
# rmdir *
# for i in `seq 1000`; do mkdir $i; done
# rmdir *
# for i in `seq 1000`; do while :; do ls $i/ >/dev/null; done & done
# while :; do killall ls; done
kernfs_node_cache in /proc/slabinfo keeps going up as expected.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org # goes way back to original sysfs days
Link: https://lore.kernel.org/r/20190805173404.GF136335@devbig004.ftw2.facebook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/dlm/lowcomms.c')
0 files changed, 0 insertions, 0 deletions