summaryrefslogtreecommitdiff
path: root/firmware/ihex2fw.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-04-01 16:23:45 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2011-04-20 14:11:45 -0700
commit48c59f4b915caf4007e6d5a1f34b10fe10210b72 (patch)
tree11ed80dadf4ae928cbffd607fbdc645dba4670ce /firmware/ihex2fw.c
parent60d5c9f5b6a2f5ce09712b7f7d0b0bf979a150be (diff)
drivers/staging/intel_sst/intel_sst_app_interface.c: introduce missing kfree
Stream_bufs is initialized at the beginning of the function, and then the #ifdef code declares a new variable with the same name and initializes that. If the if in the ifdef is taken, the then branch returns, implying that the first stream_bufs is never used and is leaked. The first initialization is thus moved down after the ifdef. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'firmware/ihex2fw.c')
0 files changed, 0 insertions, 0 deletions