diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-03 19:47:33 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-02-04 20:29:47 -0800 |
| commit | f339664c0be145b381c788bc0d5c07fbe1dd9d85 (patch) | |
| tree | 8eb0d8b337769a0bcf84215c69ca8b74f63c3c81 /drivers | |
| parent | 9ba11ac04ee89fc624abc73cbe7a8a62ddbbba06 (diff) | |
IBM-EMAC: Delete an unnecessary check before the function call "of_dev_put"
The of_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/ibm/emac/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c index 9388a83818f2..162762d1a12c 100644 --- a/drivers/net/ethernet/ibm/emac/core.c +++ b/drivers/net/ethernet/ibm/emac/core.c @@ -2367,7 +2367,7 @@ static int emac_wait_deps(struct emac_instance *dev) err = emac_check_deps(dev, deps) ? 0 : -ENODEV; for (i = 0; i < EMAC_DEP_COUNT; i++) { of_node_put(deps[i].node); - if (err && deps[i].ofdev) + if (err) of_dev_put(deps[i].ofdev); } if (err == 0) { |