diff options
| author | Saeed Mahameed <saeedm@mellanox.com> | 2018-02-07 20:48:43 -0800 |
|---|---|---|
| committer | Saeed Mahameed <saeedm@mellanox.com> | 2018-02-15 00:30:00 -0800 |
| commit | d2ff4fa575000058def5f5c602784e233211d4e7 (patch) | |
| tree | 0b37d5dc6b52a0856f9bcb66cb29916a0c4e198f /drivers | |
| parent | 02d92f7903647119e125b24f5470f96cee0d4b4b (diff) | |
net/mlx5: Add missing likely/unlikely hints to cq events
If a hardware event is targeting a CQ, that CQ should exist.
Add unlikely to error handling flows.
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Reviewed-by: Gal Pressman <galp@mellanox.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx5/core/cq.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cq.c b/drivers/net/ethernet/mellanox/mlx5/core/cq.c index dfbeeaa43276..9feeb555e937 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cq.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cq.c @@ -97,7 +97,7 @@ void mlx5_cq_completion(struct mlx5_eq *eq, u32 cqn) refcount_inc(&cq->refcount); spin_unlock(&table->lock); - if (!cq) { + if (unlikely(!cq)) { mlx5_core_warn(eq->dev, "Completion event for bogus CQ 0x%x\n", cqn); return; } @@ -118,12 +118,12 @@ void mlx5_cq_event(struct mlx5_eq *eq, u32 cqn, int event_type) spin_lock(&table->lock); cq = radix_tree_lookup(&table->tree, cqn); - if (cq) + if (likely(cq)) refcount_inc(&cq->refcount); spin_unlock(&table->lock); - if (!cq) { + if (unlikely(!cq)) { mlx5_core_warn(eq->dev, "Async event for bogus CQ 0x%x\n", cqn); return; } |