diff options
| author | Christian König <christian.koenig@amd.com> | 2016-02-22 15:11:56 +0100 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2016-02-26 01:50:18 -0500 |
| commit | 70eacc72dbbc229013fee54550c03179f9a513d8 (patch) | |
| tree | 021da08b98b98d37c70dd6ddba62d4acbb199ba6 /drivers | |
| parent | 0994c09c0412591ccd7303eec263a9dc5119c653 (diff) | |
drm/amdgpu: fix error handling in amdgpu_bo_list_set
Don't leak BOs in case of some error.
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c index 90d6fc1618aa..4792f9d0b7d4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c @@ -118,6 +118,7 @@ static int amdgpu_bo_list_set(struct amdgpu_device *adev, usermm = amdgpu_ttm_tt_get_usermm(entry->robj->tbo.ttm); if (usermm) { if (usermm != current->mm) { + amdgpu_bo_unref(&entry->robj); r = -EPERM; goto error_free; } @@ -151,6 +152,8 @@ static int amdgpu_bo_list_set(struct amdgpu_device *adev, return 0; error_free: + while (i--) + amdgpu_bo_unref(&array[i].robj); drm_free_large(array); return r; } |