diff options
author | Todd Poynor <toddpoynor@google.com> | 2018-07-21 06:35:03 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-24 13:56:46 +0200 |
commit | 040c626008e9e2f332caf16f25f2ca708cfcc480 (patch) | |
tree | 2974e8732ce082a4031c032ffb2fa5a41fb36ab1 /drivers | |
parent | 6b18580bad320fe96e32216bd91ba9f036119d25 (diff) |
staging: gasket: interrupts: convert various logs to debug level
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/staging/gasket/gasket_interrupt.c | 24 |
1 files changed, 12 insertions, 12 deletions
diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c index d096ce73cc8b..2b8c26d06533 100644 --- a/drivers/staging/gasket/gasket_interrupt.c +++ b/drivers/staging/gasket/gasket_interrupt.c @@ -287,7 +287,7 @@ int gasket_interrupt_reinit(struct gasket_dev *gasket_dev) int ret; if (!gasket_dev->interrupt_data) { - gasket_log_error( + gasket_log_debug( gasket_dev, "Attempted to reinit uninitialized interrupt data."); return -EINVAL; @@ -305,7 +305,7 @@ int gasket_interrupt_reinit(struct gasket_dev *gasket_dev) case PCI_MSI: case PLATFORM_WIRE: default: - gasket_nodev_error( + gasket_nodev_debug( "Cannot handle unsupported interrupt type %d.", gasket_dev->interrupt_data->type); ret = -EINVAL; @@ -351,7 +351,7 @@ static void gasket_interrupt_setup(struct gasket_dev *gasket_dev) gasket_dev->interrupt_data; if (!interrupt_data) { - gasket_log_error( + gasket_log_debug( gasket_dev, "Interrupt data is not initialized."); return; } @@ -365,7 +365,7 @@ static void gasket_interrupt_setup(struct gasket_dev *gasket_dev) } if (interrupt_data->type != PCI_MSIX) { - gasket_nodev_error( + gasket_nodev_debug( "Cannot handle unsupported interrupt type %d.", interrupt_data->type); return; @@ -403,7 +403,7 @@ static void gasket_interrupt_setup(struct gasket_dev *gasket_dev) pack_shift = 3 * interrupt_data->pack_width; break; default: - gasket_nodev_error( + gasket_nodev_debug( "Found interrupt description with " "unknown enum %d.", interrupt_data->interrupts[i].packing); @@ -445,7 +445,7 @@ void gasket_interrupt_cleanup(struct gasket_dev *gasket_dev) case PCI_MSI: case PLATFORM_WIRE: default: - gasket_nodev_error( + gasket_nodev_debug( "Cannot handle unsupported interrupt type %d.", interrupt_data->type); }; @@ -460,18 +460,18 @@ void gasket_interrupt_cleanup(struct gasket_dev *gasket_dev) int gasket_interrupt_system_status(struct gasket_dev *gasket_dev) { if (!gasket_dev->interrupt_data) { - gasket_nodev_info("Interrupt data is null."); + gasket_nodev_debug("Interrupt data is null."); return GASKET_STATUS_DEAD; } if (!gasket_dev->interrupt_data->msix_configured) { - gasket_nodev_info("Interrupt not initialized."); + gasket_nodev_debug("Interrupt not initialized."); return GASKET_STATUS_LAMED; } if (gasket_dev->interrupt_data->num_configured != gasket_dev->interrupt_data->num_interrupts) { - gasket_nodev_info("Not all interrupts were configured."); + gasket_nodev_debug("Not all interrupts were configured."); return GASKET_STATUS_LAMED; } @@ -516,14 +516,14 @@ static ssize_t interrupt_sysfs_show( gasket_dev = gasket_sysfs_get_device_data(device); if (!gasket_dev) { - gasket_nodev_error( + gasket_nodev_debug( "No sysfs mapping found for device 0x%p", device); return 0; } gasket_attr = gasket_sysfs_get_attr(device, attr); if (!gasket_attr) { - gasket_nodev_error( + gasket_nodev_debug( "No sysfs attr data found for device 0x%p", device); gasket_sysfs_put_device_data(device, gasket_dev); return 0; @@ -545,7 +545,7 @@ static ssize_t interrupt_sysfs_show( ret = total_written; break; default: - gasket_log_error( + gasket_log_debug( gasket_dev, "Unknown attribute: %s", attr->attr.name); ret = 0; break; |